KEMBAR78
Ensure the Pool implementation for the test class implements the new abstract method config() by violetagg · Pull Request #2098 · reactor/reactor-netty · GitHub
Skip to content

Ensure the Pool implementation for the test class implements the new abstract method config() #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2022
Merged

Ensure the Pool implementation for the test class implements the new abstract method config() #2098

merged 2 commits into from
Mar 11, 2022

Conversation

@violetagg
Copy link
Member

This is related to reactor/reactor-pool#156

@violetagg violetagg added the type/chore A task not related to code (build, formatting, process, ...) label Mar 11, 2022
@violetagg violetagg added this to the 1.1.0-M1 milestone Mar 11, 2022
@violetagg violetagg requested a review from a team March 11, 2022 10:52
@simonbasle
Copy link
Contributor

it could also be throw new UnsupportedOperationException("..."), but for tests I guess this doesn't really matter.

@violetagg
Copy link
Member Author

@simonbasle Thanks for the review!

@violetagg violetagg merged commit 174b7c2 into main Mar 11, 2022
@violetagg violetagg deleted the reactor-pool-config branch March 11, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@simonbasle simonbasle simonbasle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/chore A task not related to code (build, formatting, process, ...)

Projects

None yet

Milestone

1.1.0-M1

Development

Successfully merging this pull request may close these issues.

2 participants

@violetagg @simonbasle