Remove deprecated APIs (fifo/lifo...) #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes deprecated APIs and underlying outdated code: - `fifo()` vs `lifo()` distinction (for pending borrowers) - `DefaultPoolConfig` constructor without the `evictInBackground` parameter or without the `idleLru` parameter - default implementation of `Pool#config()` (all pool implementations should now expose their configuration) This also adjusts the CommonPoolTest to remove lifo/fifo scenarios and distinction. Fixes #112.
simonbasle
added
type/chore
violetagg
approved these changes
Mar 10, 2022
violetagg
added a commit
to reactor/reactor-netty
that referenced
this pull request
Mar 11, 2022
…abstract method config() This is related to reactor/reactor-pool#156
violetagg
added a commit
to reactor/reactor-netty
that referenced
this pull request
Mar 11, 2022
…abstract method config() (#2098) This is related to reactor/reactor-pool#156
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes deprecated APIs and underlying outdated code:
fifo()vslifo()distinction (for pending borrowers)DefaultPoolConfigconstructor without theevictInBackgroundparameter or without the
idleLruparameterPool#config()(all pool implementationsshould now expose their configuration)
This also adjusts the CommonPoolTest to remove lifo/fifo scenarios and
distinction.
Fixes #112.