Fix Integer Overflow Vulnerability in Buffer Write Method #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request addresses a security vulnerability in the write() method that could lead to potential buffer overflow attacks through integer overflow in array bounds checking. The original implementation used a pattern vulnerable to integer overflow by checking array bounds with offset + length > b.length. This can be bypassed when both offset and length are large values that, when added, overflow to become a small value that passes the boundary check. This vulnerability was also identified in ReadyTalk/avian@0871979 and subsequently fixed. References: 1. ReadyTalk/avian@0871979 2. https://nvd.nist.gov/vuln/detail/cve-2020-9488
|
Thank you for both identifying the vulnerability in Robocode, and also provide a PR for fixing it. ❤️ I will study the CVE and fix, and probably merge the PR as-is, unless it needs some extra consideration. |
…header. Copy and paste error?!
flemming-n-larsen
approved these changes
May 13, 2025
There was a problem hiding this comment.
- I removed a misplacement of the (same) write() method before the header of the RobotFileOutputStream breaking the compilation completely.
- Formatted the code as well.
Your vulnability fix of the RobotFileOutputStream.write() looks correct to be regarding checking the boundaries for off and len
flemming-n-larsen
added a commit
that referenced
this pull request
May 13, 2025
|
Thank you @flemming-n-larsen for merging my PR. I will be submitting this as a CVE, do let me know if there are any concerns ! |
|
You are welcome to summit this a a CVE. And thank you for your help. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses a security vulnerability in the write() method that could lead to potential buffer overflow attacks through integer overflow in array bounds checking.
The original implementation used a pattern vulnerable to integer overflow by checking array bounds with offset + length > b.length. This can be bypassed when both offset and length are large values that, when added, overflow to become a small value that passes the boundary check.
This vulnerability was also identified in ReadyTalk/avian@0871979 and subsequently fixed.
References: