[Fix #14318] Add WaywardPredicates config to Naming/PredicateMethod to handle methods that look like predicates but aren't
#14327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Jun 25, 2025
config/default.yml
Outdated
| AllowedPatterns: [] | ||
| AllowBangMethods: false | ||
| # Methods that are known to not return a boolean value, despite ending in `?`. | ||
| NonBooleanPredicates: |
There was a problem hiding this comment.
I'm fine with the PR in general, I'm only wondering if we can come up with a better name for this, as predicates are supposed to return booleans, so it sounds odd when I read it. I'm thinking of something more fun like:
OutlawPredicatesDeviantPredicatesWaywardPredicates
:D
There was a problem hiding this comment.
Haha alright, I've changed it to WaywardPredicates now.
…teMethod` to handle methods that look like predicates but aren't
dvandersluis
force-pushed
the
issue/14318
branch
from
702908e to
a2e7fe8
Compare
dvandersluis
changed the title
NonBooleanPredicates config to Naming/PredicateMethod to handle methods that look like predicates but aren'tWaywardPredicates config to Naming/PredicateMethod to handle methods that look like predicates but aren't
|
Now that's proper RuboCop naming! 😁 Thanks for tackling this! |
dvandersluis
added a commit
that referenced
this pull request
Jun 26, 2025
In #14327 the new configuration name was changed but I forgot to update the changelog.
viralpraxis
pushed a commit
to viralpraxis/rubocop
that referenced
this pull request
Jul 3, 2025
In rubocop#14327 the new configuration name was changed but I forgot to update the changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows
Naming/PredicateMethodto be aware of methods that look like predicates but do not return a boolean value, when determining if a method's return value is boolean.Fixes #14318.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.