Enhance Naming/MethodName cop to detect offenses within Data members
#14374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Jul 20, 2025
Comment on lines
109
to
110
| # @!method new_data?(node) | ||
| def_node_matcher :new_data?, '(send (const {nil? cbase} :Data) :define ...)' |
There was a problem hiding this comment.
Perhaps define_data is more appropriate than new_data?
Suggested change
| # @!method new_data?(node) | |
| def_node_matcher :new_data?, '(send (const {nil? cbase} :Data) :define ...)' | |
| # @!method define_data?(node) | |
| def_node_matcher :define_data?, '(send (const {nil? cbase} :Data) :define ...)' |
This is a follow-up to rubocop#14325.
viralpraxis
force-pushed
the
enhance-naming-method-name-cop-to-detect-offenses-within-data-members
branch
from
bdc0737 to
70e997b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #14325.
Before submitting the PR make sure the following are checked:
master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.