Make Lint/RedundantSafeNavigation aware of builtin methods
#14375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes `Lint/RedundantSafeNavigation` aware of builtin convert methods `to_s`, `to_i`, `to_f`, `to_a, and `to_h`. ```ruby # bad foo.to_s&.strip foo.to_i&.zero? foo.to_f&.zero? foo.to_a&.size foo.to_h&.size # good foo.to_s.strip foo.to_i.zero? foo.to_f.zero? foo.to_a.size foo.to_h.size ``` These conversion methods don't return `nil`.
koic
deleted the
make_lint_redundant_safe_navigation_aware_of_builtin_methods
branch
viralpraxis
added a commit
to viralpraxis/rubocop
that referenced
this pull request
Jul 20, 2025
koic
added a commit
that referenced
this pull request
Jul 20, 2025
Follow-up to #14375: fix changelog entry
5hun-s
pushed a commit
to 5hun-s/rubocop
that referenced
this pull request
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
Lint/RedundantSafeNavigationaware of builtin convert methodsto_s,to_i,to_f,to_a, andto_h.These conversion methods don't return
nil.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.