-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Fix Style/SafeNavigation cop to preserve existing safe navigation in check #14424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
koic
merged 1 commit into
rubocop:master
from
martinemde:martinemde/fix-incorrect-autocorrect-style-safe-navigation
Aug 6, 2025
Merged
Fix Style/SafeNavigation cop to preserve existing safe navigation in check #14424
koic
merged 1 commit into
rubocop:master
from
martinemde:martinemde/fix-incorrect-autocorrect-style-safe-navigation
Aug 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1438096 to
4ba7e30
Compare
martinemde
commented
Aug 5, 2025
koic
reviewed
Aug 5, 2025
koic
reviewed
Aug 5, 2025
koic
reviewed
Aug 5, 2025
koic
reviewed
Aug 5, 2025
koic
reviewed
Aug 5, 2025
Can you add a changelog entry? |
37844b4 to
3cd2db7
Compare
Fixes issue where 'variable&.foo ? variable.foo.bar : nil' was incorrectly corrected to 'variable.foo&.bar' instead of the correct 'variable&.foo&.bar' - Fixes: foo&.bar && foo.bar.baz → foo&.bar&.baz - Fixes: if foo&.bar; foo.bar.baz; end → foo&.bar&.baz - Fixes: foo&.bar ? foo.bar.baz : nil → foo&.bar&.baz Co-authored-by: Koichi ITO <koic.ito@gmail.com>
3cd2db7 to
6ecbee7
Compare
|
This is ready |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where safe navigation is lost when it exists in the check. For example, "check if the variable is not nil and the method call
fooon that object doesn't return nil, if so, callbaron the result, else nil":This fixes the autocorrect from the incorrect behavior that omits the original safe navigation, to the correct behavior that preserves the existing safe navigation.
Fixes:
This relates to a comment I placed in #14420. Fixing the issue with this PR rather than opening a new issue.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.