[Fix #14453] Update Style/RedundantBegin to register begin blocks inside if, unless, case, while and until as redundant
#14463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice! another similar case that comes to mind is while cond?
begin
foo
bar
end
end |
dvandersluis
force-pushed
the
issue/14453
branch
from
e9da02c to
b3ab35f
Compare
|
Thanks @vlad-pisanov I added support for |
dvandersluis
changed the title
Style/RedundantBegin to register begin blocks inside if, unless and case as redundantStyle/RedundantBegin to register begin blocks inside if, unless, case, when and until as redundant
dvandersluis
changed the title
Style/RedundantBegin to register begin blocks inside if, unless, case, when and until as redundantStyle/RedundantBegin to register begin blocks inside if, unless, case, while and until as redundant
… blocks inside `if`, `unless`, `case`, `while` and `until` as redundant
dvandersluis
force-pushed
the
issue/14453
branch
from
b3ab35f to
d7fc2a6
Compare
bbatsov
approved these changes
Aug 19, 2025
koic
added a commit
to koic/rubocop
that referenced
this pull request
Aug 22, 2025
Follow-up to rubocop#14463. This PR makes `Style/RedundantBegin` aware of `case` pattern matching.
8 tasks
bbatsov
pushed a commit
that referenced
this pull request
Aug 22, 2025
Follow-up to #14463. This PR makes `Style/RedundantBegin` aware of `case` pattern matching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
beginblock (withoutrescueorensure) insideif,case,whileoruntilis redundant, and can be handled by the cop.Fixes #14453.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.