Fix a false negative for Style/RedundantBegin
#14473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a false negative for `Style/RedundantBegin` using `begin` with multiple statements without `rescue` or `ensure`.
koic
force-pushed
the
fix_false_negative_for_style_redundant_begin
branch
from
de2e5b7 to
6b5c6ac
Compare
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Aug 25, 2025
… LSP when analyzing as Ruby 3.4 After autocorrect happened, it still reused it the parse result from the initial file, causing all kind of trouble.
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Aug 25, 2025
… LSP when analyzing as Ruby 3.4 After autocorrect happened, it still reused it the parse result from the initial file, causing all kind of trouble.
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Aug 25, 2025
… LSP when analyzing as Ruby 3.4 After autocorrect happened, it still reused it the parse result from the initial file, causing all kind of trouble.
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Aug 25, 2025
… LSP when analyzing as Ruby 3.4 After autocorrect happened, it still reused it the parse result from the initial file, causing all kind of trouble.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a false negative for
Style/RedundantBeginusingbeginwith multiple statements withoutrescueorensure.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.