[Fix #14475] Fix cop errors during autocorrect for the buildin LSP when analyzing as Ruby 3.4 #14478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
commented
Aug 25, 2025
| # rubocop:disable Metrics/AbcSize, Metrics/MethodLength | ||
| def with_server( | ||
| source = nil, path = 'fake.rb', pwd: '..', stub_no_typechecker: false, load_addons: true | ||
| source = nil, path = 'fake.rb', stub_no_typechecker: false, load_addons: true |
There was a problem hiding this comment.
I removed the pwd option. This test is already isolated and going one dir down interferes with the .rubocop.yml created in the test
| RUBY | ||
| end | ||
|
|
||
| context 'with prism as the parser' do |
There was a problem hiding this comment.
This test is very specific but I couldn't come up with a better one. This does run into an infinite loop before this change
Earlopain
force-pushed
the
lsp-autocorrect-prism-reuse
branch
2 times, most recently
from
b8d792d to
d011636
Compare
… LSP when analyzing as Ruby 3.4 After autocorrect happened, it still reused it the parse result from the initial file, causing all kind of trouble.
Earlopain
force-pushed
the
lsp-autocorrect-prism-reuse
branch
from
d011636 to
609a4a0
Compare
Earlopain
changed the title
|
Your changes seem good to me. Thanks! |
This was referenced Aug 26, 2025
Earlopain
added a commit
to Earlopain/ruby-lsp
that referenced
this pull request
Aug 27, 2025
RuboCop 1.80.1 contains a fix for why this was broken, so it should be safe to enable this again. Revert: Shopify#3672 Fix: rubocop/rubocop#14478
Earlopain
added a commit
to Earlopain/ruby-lsp
that referenced
this pull request
Aug 27, 2025
RuboCop 1.80.1 contains a fix for why this was broken, so it should be safe to enable this again. Revert: Shopify#3672 Fix: rubocop/rubocop#14478
Earlopain
added a commit
to Earlopain/ruby-lsp
that referenced
this pull request
Aug 27, 2025
RuboCop 1.80.1 contains a fix for why this was broken, so it should be safe to enable this again. Revert: Shopify#3672 Fix: rubocop/rubocop#14478
vinistock
pushed a commit
to Shopify/ruby-lsp
that referenced
this pull request
Aug 28, 2025
RuboCop 1.80.1 contains a fix for why this was broken, so it should be safe to enable this again. Revert: #3672 Fix: rubocop/rubocop#14478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14475
After autocorrect happened, it still reused it the parse result from the initial file, causing all kind of trouble.
cc @vinistock
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.