Enhance Lint/ConstantOverwrittenInRescue to detect offenses within nested constants
#14575
+36
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viralpraxis
force-pushed
the
enhance-constant-overwritten-in-rescue-to-detect-nested-constant-name
branch
from
1d108f2 to
5dc1d76
Compare
…nested constants Follow-up to rubocop#14566
viralpraxis
force-pushed
the
enhance-constant-overwritten-in-rescue-to-detect-nested-constant-name
branch
from
5dc1d76 to
4c370f7
Compare
viralpraxis
changed the title
Lint::ConstantOverwrittenInRescue` to detect offenses within nested constantsLint/ConstantOverwrittenInRescue` to detect offenses within nested constants
viralpraxis
changed the title
Lint/ConstantOverwrittenInRescue` to detect offenses within nested constantsLint/ConstantOverwrittenInRescue to detect offenses within nested constants
|
Thanks! |
viralpraxis
deleted the
enhance-constant-overwritten-in-rescue-to-detect-nested-constant-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #14566
Before submitting the PR make sure the following are checked:
master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.