[Fix #14552] Improve Security/JSONLoad documentation and implementation
#14600
+59
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lementation Things have somewhat changed since this cop was added. In addition, it should not register an offense when `create_additions` is explicitly passed. The user has made a concious decision in that case. Removed docs for `quirks_mode`, that has been gone since 2.0.0 from the 2015. It just works now, no need to bother users with this anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14552
Things have somewhat changed since this cop was added.
In addition, it should not register an offense when
create_additionsis explicitly passed.create_additionsis the option that controls deserialization behavior. If it is specified, we should assume the user knows what is going on.Removed docs for
quirks_mode, that has been gone since 2.0.0 from the 2015. It just works now, no need to bother users with this anymore.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.