[Fix #6132] Fix a false negative for Naming/FileName
#6145
Conversation
koic
force-pushed
the
fix_false_nagative_for_naming_file_name
branch
3 times, most recently
from
f6bb55e to
507a33e
Compare
lib/rubocop/config.rb
Outdated
There was a problem hiding this comment.
I think this if statement can be converted to
pattern.to_s =~ /[A-Z]/ &&
(match_path?(pattern, relative_path) ||
match_path?(pattern, absolute_path))That way the else can be eliminated entirely.
Also, what kind of object is pattern? Assuming that pattern is a symbol, to_s is unnecessary because =~ works with symbols.
There was a problem hiding this comment.
That way the else can be eliminated entirely.
Oh, I see! I fixed the conditional expression simple.
Also, what kind of object is
pattern?
If !ruby/regexp /regexp$/ is written in Include of .rubocop.yml, a Regexp instance is returned.
https://github.com/rubocop-hq/rubocop/blob/1bff66b2b8bafd215c106ee06411277d5554581d/spec/rubocop/cli_spec.rb#L996
In that case this code need to_s to prevent TypeError.
There was a problem hiding this comment.
If !ruby/regexp /regexp$/ is written in Include of .rubocop.yml, a Regexp instance is returned.
That makes more sense. I wasn't even thinking about pattern being regex. I'm so used to the paradigm of to_s =~ // being used unnecessarily with symbols.
Fixes rubocop#6132. ### Summary This PR fixes a false negative for `Naming/FileName` when `Include` of `AllCops` is the default setting. The important change in this PR is below. ```diff diff --git a/lib/rubocop/cop/naming/file_name.rb b/lib/rubocop/cop/naming/file_name.rb index a025a73..be3f1c5aa 100644 --- a/lib/rubocop/cop/naming/file_name.rb +++ b/lib/rubocop/cop/naming/file_name.rb @@ -32,7 +32,7 @@ module RuboCop def investigate(processed_source) file_path = processed_source.file_path - return if config.file_to_include?(file_path) + return if config.file_to_exclude?(file_path) ``` The problem is that the target to be excluded was `Include` instead of `Exclude`. Also this PR adds the `RuboCop::Config#allowed_camel_case_file?` method to judge ignoring `Gemfile`, `Rakefile`, etc described in` Include`. ### Other Information This false negative was noticed by adding `**/*.rb` to config/default.yml at rubocop#5882. https://github.com/rubocop-hq/rubocop/pull/5882/files#diff-e93280b3b31a6438c533a5f3232340d8R18
koic
force-pushed
the
fix_false_nagative_for_naming_file_name
branch
from
507a33e to
28d3daf
Compare
Follow up of rubocop#6145. This is the above overlook. This PR updates the configuration comment to the behavior of `Naming/FileName` that changed with rubocop#6145.
3 participants
Fixes #6132.
Summary
This PR fixes a false negative for
Naming/FileNamewhenIncludeofAllCopsis the default setting.The important change in this PR is below.
The problem is that the target to be excluded was
Includeinstead ofExclude.Also this PR adds the
RuboCop::Config#allowed_camel_case_file?method to judge ignoringGemfile,Rakefile, etc described inInclude.Other Information
This false negative was noticed by adding
**/*.rbto config/default.yml at #5882.https://github.com/rubocop-hq/rubocop/pull/5882/files#diff-e93280b3b31a6438c533a5f3232340d8R18
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
rake defaultorrake parallel. It executes all tests and RuboCop for itself, and generates the documentation.