Improve APIs for Globally Enabling/Disabling fast_fallback in Socket #12257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shioimm
force-pushed
the
improve-tcp_fast_fallback-api
branch
2 times, most recently
from
7dd8970 to
b7b1168
Compare
shioimm
changed the title
Socket.tcp_fast_fallbackSocket.tcp_fast_fallback= / Socket.tcp_fast_fallback
shioimm
force-pushed
the
improve-tcp_fast_fallback-api
branch
2 times, most recently
from
cf8229b to
c723880
Compare
This change includes the following updates:
- Added an environment variable `RUBY_TCP_NO_FAST_FALLBACK` to control enabling/disabling fast_fallback
- Updated documentation and man pages
- Revised the implementation of Socket.tcp_fast_fallback= and Socket.tcp_fast_fallback, which previously performed dynamic name resolution of constants and variables. As a result, the following performance improvements were achieved:
(Case of 1000 executions of `TCPSocket.new` to the local host)
Rehearsal -----------------------------------------
before 0.031462 0.147946 0.179408 ( 0.249279)
after 0.031164 0.146839 0.178003 ( 0.346935)
-------------------------------- total: 0.178003sec
user system total real
before 0.027584 0.138712 0.166296 ( 0.233356)
after 0.025953 0.127608 0.153561 ( 0.237971)
shioimm
force-pushed
the
improve-tcp_fast_fallback-api
branch
from
c723880 to
62c63a9
Compare
shioimm
changed the title
Socket.tcp_fast_fallback= / Socket.tcp_fast_fallback
headius
added a commit
to headius/jruby
that referenced
this pull request
Mar 13, 2025
This is used by the new fast fallback algorithm for the Socket.tcp method. This appears to be the only C change needed. See the following PRs for the bulk of the related logic: * ruby/ruby#9374 * ruby/ruby#11187 * ruby/ruby#12257
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes the following updates:
RUBY_TCP_NO_FAST_FALLBACKto control enabling/disabling fast_fallback(Case of 1000 executions of
TCPSocket.newto the local host)Additionally, documentation for these methods has been added.