Rewrite gdb pretty-printer registration #116978

tromey · 2023-10-20T14:55:51Z

Currently, the Rust pretty-printers are registered in gdb using the uninformative name "lookup":

(gdb) info pretty-printer
global pretty-printers:
[...]
objfile /home/tromey/[...]
  lookup

It's nicer for users if the top-level registration is given a clear name. Additionally, gdb lets users individually enable and disable specific printers, provided they are registered correctly.

This patch implements both these ideas. Now the output looks like:

(gdb) info pretty-printer
global pretty-printers:
[...]
objfile /home/tromey/[...]
  rust
StdArc
StdBTreeMap
StdBTreeSet
StdCell
StdHashMap
StdHashSet
StdNonZeroNumber
StdOsString
StdRc
StdRef
StdRefCell
StdRefMut
StdSlice
StdStr
StdString
StdVec
StdVecDeque

rustbot · 2023-10-20T14:55:59Z

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

tromey · 2023-10-20T16:34:23Z

I fixed the obvious issue. I notice though that ./x.py test doesn't really seem to work here, it prints a lot of stuff about formatting nits that have nothing to do with my change instead.

Currently, the Rust pretty-printers are registered in gdb using the uninformative name "lookup": (gdb) info pretty-printer global pretty-printers: [...] objfile /home/tromey/[...] lookup It's nicer for users if the top-level registration is given a clear name. Additionally, gdb lets users individually enable and disable specific printers, provided they are registered correctly. This patch implements both these ideas. Now the output looks like: (gdb) info pretty-printer global pretty-printers: [...] objfile /home/tromey/[...] rust StdArc StdBTreeMap StdBTreeSet StdCell StdHashMap StdHashSet StdNonZeroNumber StdOsString StdRc StdRef StdRefCell StdRefMut StdSlice StdStr StdString StdVec StdVecDeque

Mark-Simulacrum · 2023-10-21T18:11:37Z

@bors r+

bors · 2023-10-21T18:11:39Z

📌 Commit e98beb5 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors · 2023-10-22T10:04:57Z

⌛ Testing commit e98beb5 with merge 152f810...

…-Simulacrum Rewrite gdb pretty-printer registration Currently, the Rust pretty-printers are registered in gdb using the uninformative name "lookup": (gdb) info pretty-printer global pretty-printers: [...] objfile /home/tromey/[...] lookup It's nicer for users if the top-level registration is given a clear name. Additionally, gdb lets users individually enable and disable specific printers, provided they are registered correctly. This patch implements both these ideas. Now the output looks like: (gdb) info pretty-printer global pretty-printers: [...] objfile /home/tromey/[...] rust StdArc StdBTreeMap StdBTreeSet StdCell StdHashMap StdHashSet StdNonZeroNumber StdOsString StdRc StdRef StdRefCell StdRefMut StdSlice StdStr StdString StdVec StdVecDeque

rust-log-analyzer · 2023-10-22T11:03:30Z

The job i686-mingw failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [ui] tests\ui\runtime\backtrace-debuginfo.rs stdout ----

error: test run failed!
status: exit code: 101
command: PATH="C:\a\rust\rust\build\i686-pc-windows-gnu\stage2\lib\rustlib\i686-pc-windows-gnu\lib;C:\a\rust\rust\build\i686-pc-windows-gnu\stage0-bootstrap-tools\i686-pc-windows-gnu\release\deps;C:\a\rust\rust\build\i686-pc-windows-gnu\stage0\bin;C:\a\rust\rust\ninja;C:\a\rust\rust\mingw32\bin;C:\hostedtoolcache\windows\Python\3.12.0\x64\Scripts;C:\hostedtoolcache\windows\Python\3.12.0\x64;C:\msys64\usr\bin;C:\a\rust\rust\sccache;C:\PROGRA~1\MongoDB\bin;C:\aliyun-cli;C:\vcpkg;C:\cf-cli;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\2.13.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 5.7\bin;C:\Program Files\R\R-4.3.1\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.20.10\x64\bin;C:\hostedtoolcache\windows\Python\3.7.9\x64\Scripts;C:\hostedtoolcache\windows\Python\3.7.9\x64;C:\hostedtoolcache\windows\Ruby\2.5.9\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.382-5\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\Program Files\Eclipse Foundation\jdk-8.0.302.8-hotspot\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\ProgramData\Chocolatey\bin;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\Microsoft SQL Server\110\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\150\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\TortoiseSVN\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.7\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\SeleniumWebDrivers\ChromeDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files (x86)\Google\Cloud SDK\google-cloud-sdk\bin;C:\Program Files (x86)\Microsoft BizTalk Server;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\test\\ui\\runtime\\backtrace-debuginfo\\a.exe"
---------------------------------------
trace does not match position list
trace does not match position list
still need to find ["backtrace-debuginfo.rs:184"]
--- stdout
backtrace-debuginfo.rs:120
backtrace-debuginfo.rs:184

---
   6:  0x13d34d0 - std::panicking::begin_panic::h77fecc14404bbcd9
                       at /rustc/FAKE_PREFIX\library\std\src/panicking.rs:638:12
   7:  0x13e5c7d - backtrace_debuginfo::inner::h5b01f04da66e8433
                       at C:\a\rust\rust\tests\ui\runtime\backtrace-debuginfo.rs:81:5
   8:  0x13e636e - backtrace_debuginfo::outer::hb144f59b805e2ef5
   9:   0xa88718 - <unknown>
  10:   0xa88718 - <unknown>
  11: 0x75297671 - <unknown>
  11: 0x75297671 - <unknown>
  12:  0x13e778e - _main
  13:  0x13d1386 - ___tmainCRTStartup
  14: 0x75ea05c9 - <unknown>
  15: 0x779278bd - <unknown>
  16: 0x7792788d - <unknown>
--- stderr -------------------------------
thread 'main' panicked at C:\a\rust\rust\tests\ui\runtime\backtrace-debuginfo.rs:174:9:
found some errors
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

bors · 2023-10-22T11:03:54Z

💔 Test failed - checks-actions

ehuss · 2023-10-22T16:35:35Z

This is back in the queue after the synchronize. I believe the error is due to a flaky test.

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#116960 (Location-insensitive polonius: consider a loan escaping if an SCC has member constraints applied only) - rust-lang#116978 (Rewrite gdb pretty-printer registration) - rust-lang#117040 (coverage: Add UI tests for values accepted by `-Cinstrument-coverage`) - rust-lang#117064 (Eliminate rustc_attrs::builtin::handle_errors in favor of emitting errors directly) - rust-lang#117073 (Fix suggestion for renamed coroutines feature) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116978 - tromey:rust-printers-cleanup, r=Mark-Simulacrum Rewrite gdb pretty-printer registration Currently, the Rust pretty-printers are registered in gdb using the uninformative name "lookup": (gdb) info pretty-printer global pretty-printers: [...] objfile /home/tromey/[...] lookup It's nicer for users if the top-level registration is given a clear name. Additionally, gdb lets users individually enable and disable specific printers, provided they are registered correctly. This patch implements both these ideas. Now the output looks like: (gdb) info pretty-printer global pretty-printers: [...] objfile /home/tromey/[...] rust StdArc StdBTreeMap StdBTreeSet StdCell StdHashMap StdHashSet StdNonZeroNumber StdOsString StdRc StdRef StdRefCell StdRefMut StdSlice StdStr StdString StdVec StdVecDeque

rustbot assigned Mark-Simulacrum Oct 20, 2023

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2023

This comment has been minimized.

Sign in to view

tromey force-pushed the rust-printers-cleanup branch from d054528 to 67ffb44 Compare October 20, 2023 16:34

tromey force-pushed the rust-printers-cleanup branch from 67ffb44 to e98beb5 Compare October 20, 2023 16:35

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 22, 2023

matthiaskrgr mentioned this pull request Oct 23, 2023

Rollup of 5 pull requests #117087

Merged

bors merged commit 5f96976 into rust-lang:master Oct 23, 2023

rustbot added this to the 1.75.0 milestone Oct 23, 2023

tromey deleted the rust-printers-cleanup branch October 23, 2023 18:17

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rewrite gdb pretty-printer registration #116978

Rewrite gdb pretty-printer registration #116978

Uh oh!

tromey commented Oct 20, 2023

Uh oh!

rustbot commented Oct 20, 2023

Uh oh!

This comment has been minimized.

tromey commented Oct 20, 2023

Uh oh!

Mark-Simulacrum commented Oct 21, 2023

Uh oh!

bors commented Oct 21, 2023

Uh oh!

bors commented Oct 22, 2023

Uh oh!

rust-log-analyzer commented Oct 22, 2023

Uh oh!

bors commented Oct 22, 2023

Uh oh!

ehuss commented Oct 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Rewrite gdb pretty-printer registration #116978

Rewrite gdb pretty-printer registration #116978

Uh oh!

Conversation

tromey commented Oct 20, 2023

Uh oh!

rustbot commented Oct 20, 2023

Uh oh!

This comment has been minimized.

tromey commented Oct 20, 2023

Uh oh!

Mark-Simulacrum commented Oct 21, 2023

Uh oh!

bors commented Oct 21, 2023

Uh oh!

bors commented Oct 22, 2023

Uh oh!

rust-log-analyzer commented Oct 22, 2023

Uh oh!

bors commented Oct 22, 2023

Uh oh!

ehuss commented Oct 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants