KEMBAR78
fix: Correctly goto `From` impl when on `into()` even when the call is inside a macro by ChayimFriedman2 · Pull Request #20382 · rust-lang/rust-analyzer · GitHub
Skip to content

Conversation

@ChayimFriedman2
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 commented Aug 4, 2025

Descend into macros first.

Fixes #20377.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2025
Copy link
Member

@ShoyuVanilla ShoyuVanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ShoyuVanilla ShoyuVanilla added this pull request to the merge queue Aug 4, 2025
Merged via the queue into rust-lang:master with commit 4c8fb89 Aug 4, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2025
@ChayimFriedman2 ChayimFriedman2 deleted the goto-def-from-macro branch August 4, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jump from into to from definitions from within methods with macro atributes

3 participants