feat(secret_manager): allow to specify an external key id when creating a secret #4674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
secret
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4674 +/- ##
===========================================
- Coverage 75.45% 55.30% -20.15%
===========================================
Files 202 309 +107
Lines 44323 78902 +34579
===========================================
+ Hits 33444 43637 +10193
- Misses 9653 33865 +24212
- Partials 1226 1400 +174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jremy42
previously approved these changes
Apr 17, 2025
jremy42
approved these changes
Apr 17, 2025
Laure-di
pushed a commit
to scaleway-bot/scaleway-cli
that referenced
this pull request
May 15, 2025
…ng a secret (scaleway#4674) Co-authored-by: Jonathan R. <jremy@scaleway.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.