KEMBAR78
fix(instance): list images: pass arguments to the request by Mia-Cross · Pull Request #5048 · scaleway/scaleway-cli · GitHub
Skip to content

fix(instance): list images: pass arguments to the request #5048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2025
Merged

fix(instance): list images: pass arguments to the request #5048

merged 1 commit into from
Oct 10, 2025

Conversation

@Mia-Cross
Copy link
Contributor

This PR fixes a bug introduced by #5032: only organization_id and project_id arguments were correctly passed to the request.

@Mia-Cross Mia-Cross self-assigned this Oct 10, 2025
@Mia-Cross Mia-Cross added bug instance Instance issues, bugs and feature requests priority:highest Bugs filled by customers, security issues labels Oct 10, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.26%. Comparing base (5bf53e0) to head (cf7626b).
⚠️ Report is 844 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (cf7626b). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (cf7626b)
2 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #5048       +/-   ##
===========================================
- Coverage   75.45%   56.26%   -19.19%     
===========================================
  Files         202      308      +106     
  Lines       44323    78090    +33767     
===========================================
+ Hits        33444    43940    +10496     
- Misses       9653    32743    +23090     
- Partials     1226     1407      +181

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mia-Cross Mia-Cross marked this pull request as ready for review October 10, 2025 13:11
@Mia-Cross Mia-Cross requested a review from a team as a code owner October 10, 2025 13:11
@remyleone remyleone added this pull request to the merge queue Oct 10, 2025
Merged via the queue into scaleway:master with commit 2fe8430 Oct 10, 2025
16 checks passed
@Mia-Cross Mia-Cross deleted the instance_fix_list_images branch October 10, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@remyleone remyleone remyleone approved these changes

Assignees

@Mia-Cross Mia-Cross

Labels

bug instance Instance issues, bugs and feature requests priority:highest Bugs filled by customers, security issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mia-Cross @codecov-commenter @remyleone