KEMBAR78
NEVERHOOD: Fixes for japanese neverhood by phcoder · Pull Request #4677 · scummvm/scummvm · GitHub
Skip to content

Conversation

@phcoder
Copy link
Contributor

@phcoder phcoder commented Feb 2, 2023

No description provided.

This happens when attempting to play making of on japanese version when
NHC is loaded.
This is essentially same ads attempting to open the file in question but
without incurring I/O cost.
Otherwise it  creates an invisible button that can still be clicked and
results in a button press animation followed by a brief read screen.

Reported by: -=CHE@TER=-
@phcoder phcoder merged commit d3f87c9 into scummvm:master Feb 2, 2023
@raziel-
Copy link
Contributor

raziel- commented Feb 2, 2023

Isn't the Engine missing in the commit message?

Like "NEVERHOOD: Fixes for japanese version"

@sev-
Copy link
Member

sev- commented Feb 3, 2023

@raziel- Which commit specifically?

@raziel-
Copy link
Contributor

raziel- commented Feb 3, 2023

@sev-

The main PR #4677.
It says "Fixes for japanese Neverhood".
I thought the main PR message should always have the target in front?
Like GUI:, BASE:, COMMON:, JANITORIAL:, or the target engine, SCUMM:, GLK:, NEVERHOOD:?

Maybe I'm wrong, sorry for the noise

@phcoder phcoder changed the title Fixes for japanese neverhood NEVERHOOD: Fixes for japanese neverhood Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants