GRAPHICS: Use standard palettes in ManagedSurface #4730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgerhardy
reviewed
Feb 22, 2023
|
@ccawley2011 : I would prefer to close this in favor of using PR #4731 instead. OK with you? |
The two PRs do different things, though. PR #4731 removes the deprecated API so that users of ManagedSurface aren't dependent on the format of the palette, while this PR changes the format of the palette to allow code reuse, which is why the old API was deprecated in the first place. |
|
@ccawley2011 : Ah, OK. So what happens now? i.e. merge both, merge one or the other? |
lephilousophe
approved these changes
Feb 23, 2023
ccawley2011
force-pushed
the
managed-surface-palette-pt2
branch
from
36ec925 to
9f6b8ba
Compare
|
This is a good change. I always wondered why ManagedSurface used a non-standard palette format. It requires rebasing, though |
ccawley2011
force-pushed
the
managed-surface-palette-pt2
branch
from
9f6b8ba to
125640f
Compare
OK, done. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to PR #4541.