KEYMAPPER: Allow multiple inputs bound to a keymap action as defaults #4830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… defaults This allows backeds to override a keymap action mapping with lists of mapped hardware inputs instead of just one hardware input id However, it will still be an overridding, so it will require all hardware input ids for a given keymap action to be added. In other words, if a backend uses addDefaultBinding() for a given action, it will not ADD to any existing mappings of the action, other than the ones that the backend itself has added (with addDefaultBinding())
criezy
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
There is only a minor formatting issue.
Otherwise the change is simple enough, only changing a String to a StringArray to allow specifying multiple bindings for an action.
Cons: does not keep any mappings to an action that are set elsewhere -- it still overrides the mappings with new ones
Supporting the possibility to add to rather than replace bindings could indeed be a nice addition. But the change as proposed here already looks like a good improvement.
sev-
pushed a commit
that referenced
this pull request
Mar 24, 2023
…#4830) This allows backeds to override a keymap action mapping with lists of mapped hardware inputs instead of just one hardware input id However, it will still be an overridding, so it will require all hardware input ids for a given keymap action to be added. In other words, if a backend uses addDefaultBinding() for a given action, it will not ADD to any existing mappings of the action, other than the ones that the backend itself has added (with addDefaultBinding())
sev-
pushed a commit
that referenced
this pull request
Mar 24, 2023
…#4830) This allows backeds to override a keymap action mapping with lists of mapped hardware inputs instead of just one hardware input id However, it will still be an overridding, so it will require all hardware input ids for a given keymap action to be added. In other words, if a backend uses addDefaultBinding() for a given action, it will not ADD to any existing mappings of the action, other than the ones that the backend itself has added (with addDefaultBinding())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows backeds to override a keymap action mapping with lists of mapped hardware inputs instead of just one hardware input id
However, it will still be an overridding, so it will require all hardware input ids for a given keymap action to be added. In other words, if a backend uses addDefaultBinding() for a given action, it will not ADD to any existing mappings of the action, other than the ones that the backend itself has added (with addDefaultBinding())
Pros: Extended functionality, resolves an issue with Android controller devices (virtual mouse movement needing to be mapped to DPAD directional keys and (left) joystick movements).
Cons: Adds complexity to the implementation, and does not keep any mappings to an action that are set elsewhere -- it still overrides the mappings with new ones added using addDefaultBinding().