I18N: Add script to generate translated android strings.xml, automatically generates fake cpp file #4831
Conversation
|
Wouldn't it better to modify weblate configuration? (using https://docs.weblate.org/en/latest/formats.html#aresource) |
Yes, this makes sense - was trying to implement this approach from discord |
|
@lephilousophe, the idea was similar to this PR: #4826 E.g. we turn the strings.xml into a generated file and the original will sit in a Python script. That script will merge in translations from the Weblate. Unless, of course, you have an idea of how we can mark up the strings.xml file in a way that the |
ankushdutt
changed the title
ankushdutt
changed the title
|
@ankushdutt do you intend to follow out commit guidelines? |
- Add a python script (generate-android-i18n-strings.py) that generates the translated android strings.xml as per: https://developer.android.com/guide/topics/resources/providing-resources#AlternativeResources It considers the dists/android/res/values/strings.xml file as a base template to generate those translated strings.xml files. - The python script also generates a fake cpp with strings from dists/android/res/values/strings.xml. These strings will be picked up by gettext to make it translatable. If there is any change in the original strings.xml file, we won't have to worry about the changes in cpp file. - Add documentation for the generate-android-i18n-strings.py script
ankushdutt
force-pushed
the
make-strings-translatable
branch
from
3e0529a to
eafe807
Compare
Sorry yes, I have now squashed the commits with an updated commit message. |
|
Okay, rebasing and merging this |
3 participants
Description
Fixes: https://trello.com/c/EiKn4pYx/36-error-warning-and-info-messages-in-stringsxml-should-be-translate-able-via-the-weblate
This PR adds a python script that generates the translated strings.xml as per this specs: https://developer.android.com/guide/topics/resources/providing-resources#AlternativeResources
Also, this script automatically generates the fake cpp for the gettext (to make it translatable for weblate) using
res/values/strings.xml.Relevant translated strings.xml file will be automatically used based on the android system's language.
Testing
For testing, I manually added the string for the permission denied toast in the original and some generated XML (I also edited the relevant code to use string resource instead), and it works as expected.
Here are some screenshots of the android app:
Default:
Using Catalan system's language (same build):
Using Japanese system's language (same build):
