GUI: Don't redraw whole dialog stack with kRedrawTopDialog #4953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Immediately, I was thinking about tooltips overlapping the current dialog, but upon testing your code change, I was not able to catch a case when there is garbage left on the screen. As for the top dialog changing underneath, this is never the case. So, merging this. Thanks! |
|
This breaks the smooth animation when dismissing the debug console. It doesn't redraw as it scrolls back up
|
|
@sluicebox will take a look, good catch! |
|
Fixed in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something I wanted to fix for a long time: https://bugs.scummvm.org/ticket/14364
Not only it drastically speeds up button and scrolling redraws
but it makes tool tips pleasant to watch -- without this patch every tooltip freezes my backend for about 500 ms. You can imagine that user experience, one has to literally run away with mouse to avoid showing tooltips. ;)(EDIT: actually, I got carried away here -- tool tips of course still redraw the background upon closing; I've had another optimization implemented but it's not suitable for a PR yet).As I'm not a GUI expert, putting this for review whether I haven't overlooked something obvious.
From what I could see, there is only one potential risk: if there is a dialog which has the Apply button which updates something in the parent dialog. I haven't found any case like that but maybe you know better. IMHO even with this limitation this optimization is worth it on any lowend platform (content of the parent dialog would be updated on close of the child).