GLK: TADS: Add missing entries to the detection table from ifdb.org #4963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Hello Marco,
I can't wait for the Zcode update ! |
Ok, put into the todo list. Thanks! |
sluicebox
added a commit
that referenced
this pull request
Jul 12, 2024
Sierra's interpreter populated the class table and initialized objects in one pass, until SCI3. We have always been doing two passes: one to initialize the class table and then another to initialize objects. This should not make a difference, except that some scripts contain two classes with the same supposedly unique class number. When this occurs, the first class is always overwritten before it can be used, causing any objects in between to be associated with the wrong class. In 2010, this condition caused the ICEMAN demo to crash. It was worked around by adding a third pass. This prevented that particular script from crashing, but the real problem remained. Now we update the class table and initialize objects in one pass. For SCI3, we continue to use two passes like the original. - Fixes KQ5 FM-Towns save and restore dialog buttons - Fixes ICEMAN demo properly, removes workaround (bug #4963) See: 3485d43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLK: TADS: Add missing entries to the detection table from ifdb.org
This PR add missing entries from ifdb.org for GLK: TADS: subengine; scummvm compiles so it should be merged.
Be aware that in my builds the subengine seems to be broken/unsupported so I've quickly added info as they are (only very few titles have been checked with QTads).