KEMBAR78
Implement jumpToItem in JsonItemReader by jpraet · Pull Request #4557 · spring-projects/spring-batch · GitHub
Skip to content

Conversation

@jpraet
Copy link
Contributor

@jpraet jpraet commented Mar 2, 2024

No description provided.

@fmbenhassine
Copy link
Contributor

Thank you for the PR. LGTM as a candidate for v5.2.

Can you please add a test for the new method in both jackson and gson readers? Thank you upfront.

@fmbenhassine fmbenhassine added the status: waiting-for-reporter Issues for which we are waiting for feedback from the reporter label Apr 16, 2024
@jpraet jpraet force-pushed the feature/JsonItemReader-jumpToItem branch from ced71a6 to 5dc2aa0 Compare April 17, 2024 11:34
@jpraet
Copy link
Contributor Author

jpraet commented Apr 17, 2024

Can you please add a test for the new method in both jackson and gson readers? Thank you upfront.

added test

fmbenhassine pushed a commit that referenced this pull request Apr 18, 2024
@fmbenhassine
Copy link
Contributor

Thank you for the updates! Rebased and merged as ff0fb97. Thank you for your contribution.

@fmbenhassine fmbenhassine removed the status: waiting-for-reporter Issues for which we are waiting for feedback from the reporter label Apr 18, 2024
@fmbenhassine fmbenhassine added this to the 5.2.0-M1 milestone Apr 18, 2024
FBibonne pushed a commit to FBibonne/spring-batch that referenced this pull request Feb 2, 2025
Issue spring-projects#4557

Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants