KEMBAR78
Build and push `devel` Docker image on master changes via CI workflow by joseluisq · Pull Request #512 · static-web-server/static-web-server · GitHub
Skip to content

Conversation

@joseluisq
Copy link
Collaborator

@joseluisq joseluisq commented Dec 10, 2024

Description

This PR refines the work done on #508. Basically, it uses a job matrix strategy for the debian and scratch Docker image variants and makes use of an x86_64-unknown-linux-musl static binary for both images to make it work on scratch.

Note: For now, this workflow only supports one arch/target per Docker variant. However, If multiple targets are needed then it is necessary to refactor the workflow and the 'devel' Dockerfile should be adjusted accordingly to be multi-arch.

Images published only to Github Container Registry:

https://github.com/static-web-server/static-web-server/pkgs/container/static-web-server

  • ghcr.io/static-web-server/static-web-server:devel (scratch)
  • ghcr.io/static-web-server/static-web-server:devel-debian (debian)

Related Issue

Motivation and Context

Improve the work done on #508

How Has This Been Tested?

Screenshots (if appropriate):

)

* ci: build and push devel image on master

* Temporarily enable devel docker release on pull request

* add build release

* ci: build only amd64 and use devel dockerfiles

* temporarily disable login to docker hub

* fix tag

* add cache for binary

* test release binary

* move binary to the right place

* update action versions

* disable docker hub image

* test tags

* test tags

* test tags

* add permissions to scratch job

* apply feedback

* remove test step

* Address comments
@semanticdiff-com
Copy link

Review changes with  SemanticDiff

@joseluisq joseluisq changed the title Build and push devel Docker image on master changes via CI workfow Build and push devel Docker image on master changes via CI workflow Dec 10, 2024
@joseluisq joseluisq force-pushed the master-ci branch 7 times, most recently from c2cb2db to a0c4d25 Compare December 10, 2024 22:48
@joseluisq joseluisq marked this pull request as ready for review December 10, 2024 23:10
@joseluisq joseluisq added enhancement New feature or request v2 v2 release ci Related to CI/CD labels Dec 10, 2024
@joseluisq joseluisq merged commit b46a7a0 into master Dec 10, 2024
@joseluisq joseluisq deleted the master-ci branch December 10, 2024 23:16
@joseluisq
Copy link
Collaborator Author

The release-docker-devel workflow was successful after the merge. See https://github.com/static-web-server/static-web-server/actions/runs/12266415320

@joseluisq joseluisq modified the milestones: v2.34.1, v2.35.0 Jan 3, 2025
joseluisq added a commit that referenced this pull request Jan 9, 2025
joseluisq added a commit that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Related to CI/CD enhancement New feature or request v2 v2 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants