KEMBAR78
Ship PayNow by amk-stripe · Pull Request #11539 · stripe/stripe-android · GitHub
Skip to content

Ship PayNow #11539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 8, 2025
Merged

Ship PayNow #11539

merged 2 commits into from
Sep 8, 2025

Conversation

@amk-stripe
Copy link
Collaborator

@amk-stripe amk-stripe commented Sep 5, 2025 •
edited
Loading

Summary

Ship PayNow

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-3960

Testing

  • Added tests
  • Modified tests
  • Manually verified

Changelog

PaymentSheet

  • [ADDED]11539 - Added support for PayNow to PaymentSheet.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025 •
edited
Loading

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │          compressed           │          uncompressed          
          ├───────────┬───────────┬───────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff   
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼────────
      dex │   4.8 MiB │   4.8 MiB │ -17 B │  10.6 MiB │  10.6 MiB │ -232 B 
     arsc │   2.6 MiB │   2.6 MiB │   0 B │   2.6 MiB │   2.6 MiB │    0 B 
 manifest │   5.8 KiB │   5.8 KiB │   0 B │  30.1 KiB │  30.1 KiB │    0 B 
      res │ 927.6 KiB │ 927.6 KiB │   0 B │   1.5 MiB │   1.5 MiB │    0 B 
   native │   3.5 MiB │   3.5 MiB │   0 B │   8.5 MiB │   8.5 MiB │    0 B 
    asset │   1.6 MiB │   1.6 MiB │ +23 B │   1.6 MiB │   1.6 MiB │  +23 B 
    other │ 198.7 KiB │ 198.7 KiB │  -7 B │ 375.4 KiB │ 375.4 KiB │    0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼────────
    total │  13.6 MiB │  13.6 MiB │  -1 B │  25.2 MiB │  25.2 MiB │ -209 B 

         │         raw          │             unique             
         ├───────┬───────┬──────┼───────┬───────┬────────────────
 DEX     │ old   │ new   │ diff │ old   │ new   │ diff           
─────────┼───────┼───────┼──────┼───────┼───────┼────────────────
   files │     2 │     2 │    0 │       │       │                
 strings │ 53637 │ 53635 │   -2 │ 49917 │ 49915 │ -2 (+13 -15)   
   types │ 19128 │ 19127 │   -1 │ 17384 │ 17383 │ -1 (+12 -13)   
 classes │ 14679 │ 14678 │   -1 │ 14679 │ 14678 │ -1 (+0 -1)     
 methods │ 74677 │ 74676 │   -1 │ 71827 │ 71826 │ -1 (+593 -594) 
  fields │ 48740 │ 48737 │   -3 │ 47748 │ 47745 │ -3 (+153 -156) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6361 │ 6361 │  0
APK 
    compressed    │    uncompressed    │                                           
──────────┬───────┼───────────┬────────┤                                           
 size     │ diff  │ size      │ diff   │ path                                      
──────────┼───────┼───────────┼────────┼───────────────────────────────────────────
  9.3 KiB │ +23 B │   9.1 KiB │  +23 B │ ∆ assets/dexopt/baseline.prof             
  4.3 MiB │ -17 B │   9.5 MiB │ -232 B │ ∆ classes.dex                             
 55.2 KiB │  -8 B │ 122.4 KiB │    0 B │ ∆ META-INF/CERT.SF                        
 51.7 KiB │  +2 B │ 122.4 KiB │    0 B │ ∆ META-INF/MANIFEST.MF                    
    271 B │  -1 B │     120 B │    0 B │ ∆ META-INF/version-control-info.textproto 
──────────┼───────┼───────────┼────────┼───────────────────────────────────────────
  4.4 MiB │  -1 B │   9.7 MiB │ -209 B │ (total)
DEX 
STRINGS:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   49917 │ 49915 │ -2 (+13 -15) 
  
  + [LJ8/D0;
  + [LJ8/G0;
  + [LJ8/M0;
  + [LJ8/R0;
  + [LJ8/Z0;
  + [LJ8/b1;
  + [LJ8/k0;
  + [LJ8/n0;
  + [LJ8/p0;
  + [LJ8/t0;
  + [LJ8/w0;
  + [LJ8/y0;
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"f72dce1","r8-mode":"full","version":"8.8.34"}
  
  - Enable PayNow
  - LJ8/e1;
  - [LJ8/F0;
  - [LJ8/I0;
  - [LJ8/N0;
  - [LJ8/S0;
  - [LJ8/a1;
  - [LJ8/d1;
  - [LJ8/l0;
  - [LJ8/o0;
  - [LJ8/q0;
  - [LJ8/u0;
  - [LJ8/x0;
  - [LJ8/z0;
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"5c3637c","r8-mode":"full","version":"8.8.34"}
  

TYPES:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   17384 │ 17383 │ -1 (+12 -13) 
  
  + [LJ8/D0;
  + [LJ8/G0;
  + [LJ8/M0;
  + [LJ8/R0;
  + [LJ8/Z0;
  + [LJ8/b1;
  + [LJ8/k0;
  + [LJ8/n0;
  + [LJ8/p0;
  + [LJ8/t0;
  + [LJ8/w0;
  + [LJ8/y0;
  
  - LJ8/e1;
  - [LJ8/F0;
  - [LJ8/I0;
  - [LJ8/N0;
  - [LJ8/S0;
  - [LJ8/a1;
  - [LJ8/d1;
  - [LJ8/l0;
  - [LJ8/o0;
  - [LJ8/q0;
  - [LJ8/u0;
  - [LJ8/x0;
  - [LJ8/z0;
  

METHODS:

   old   │ new   │ diff           
  ───────┼───────┼────────────────
   71827 │ 71826 │ -1 (+593 -594) 
  
  + D8.M0 <init>(U0, S0, G, Continuation)
  + D8.M <init>(PaymentSheetPlaygroundActivity, S0, l0, A1, M0, x, s)
  + D8.O0 <init>(R0, U0, Continuation)
  + D8.P0 <init>(U0, S0, Continuation)
  + D8.Q0 <init>(U0, S0, Continuation)
  + D8.R0 <init>(R0, U0, Continuation)
  + D8.S0 <init>(U0, S0, Continuation)
  + D8.T0 <init>(U0, S0, Continuation)
  + D8.U0 h(U0, S0, String, ContinuationImpl) → Object
  + D8.X0 <init>(R0, String)
  + D8.X0 g(X0, R0) → X0
  + D8.X0 j() → R0
  + D8.Y0 <init>(R0, long, List, J0, String, String)
  + D8.Y0 g(Y0, R0, int) → Y0
  + D8.Y0 j() → R0
  + D8.Z0 <init>(R0, String, String)
  + D8.Z0 j() → R0
  + D8.a0 <init>(PaymentSheetPlaygroundActivity, S0, int, int)
  + D8.a1 j() → R0
  + F3.f L(M0) → L0
  + F3.f l(E0)
  + F3.f n(d, Y0, J0)
  + F3.f o(M0, Object, D0, Y0, K0, l)
  + F3.f p(r, Y0, I0)
  + F3.f q(o, X0, F0)
  + F3.f r(D0, Y0, K0)
  + F3.f s(D0, Z0, K0)
  + F9.a W(Object, String) → G0
  + G.e s() → S0
  + G.e t(String) → S0
  + I8.d <init>(R0, Context)
  + I8.j <init>(R0, Context)
  + J8.A0 serializer() → a
  + J8.A b(Object, D0, Y0, K0, l)
  + J8.A c(E0) → boolean
  + J8.A d(Object, o, X0, F0)
  + J8.A g(Object, D0, Z0, K0)
  + J8.A h(Object, D0, Y0, K0)
  + J8.A i(E0) → List
  + J8.A l() → L0
  + J8.A n(Object, d, Y0, J0)
  + J8.A o(Object, r, Y0, I0)
  + J8.A p(Object, S0)
  + J8.B0 createFromParcel(Parcel) → Object
  + J8.B0 newArray(int) → Object[]
  + J8.C0 a() → Set
  + J8.C0 serializer() → a
  + J8.C b(Object, D0, Y0, K0, l)
  + J8.C c(E0) → boolean
  + J8.C d(Object, o, X0, F0)
  + J8.C g(Object, D0, Z0, K0)
  + J8.C h(Object, D0, Y0, K0)
  + J8.C i(E0) → List
  + J8.C l() → L0
  + J8.C n(Object, d, Y0, J0)
  + J8.C o(Object, r, Y0, I0)
  + J8.C p(Object, S0)
  + J8.D0 <clinit>()
  + J8.D0 a() → boolean
  + J8.D0 b() → boolean
  + J8.D0 c() → boolean
  + J8.D0 valueOf(String) → D0
  + J8.D0 values() → D0[]
  + J8.D b(Object, D0, Y0, K0, l)
  + J8.D c(E0) → boolean
  + J8.D d(Object, o, X0, F0)
  + J8.D g(Object, D0, Z0, K0)
  + J8.D h(Object, D0, Y0, K0)
  + J8.D l() → L0
  + J8.D n(Object, d, Y0, J0)
  + J8.D o(Object, r, Y0, I0)
  + J8.D p(Object, S0)
  + J8.E0 <init>(int, D0)
  + J8.E0 <init>(D0)
  + J8.E0 describeContents() → int
  + J8.E0 equals(Object) → boolean
  + J8.E0 hashCode() → int
  + J8.E0 toString() → String
  + J8.E0 writeToParcel(Parcel, int)
  + J8.F0 <init>(o)
  + J8.F b(Object, D0, Y0, K0, l)
  + J8.F c(E0) → boolean
  + J8.F d(Object, o, X0, F0)
  + J8.F g(Object, D0, Z0, K0)
  + J8.F h(Object, D0, Y0, K0)
  + J8.F i(E0) → List
  + J8.F l() → L0
  + J8.F n(Object, d, Y0, J0)
  + J8.F o(Object, r, Y0, I0)
  + J8.F p(Object, S0)
  + J8.G0 <init>(String, Object)
  + J8.H0 i(E0) → List
  + J8.H0 q() → String
  + J8.H b(Object, D0, Y0, K0, l)
  + J8.H c(E0) → boolean
  + J8.H d(Object, o, X0, F0)
  + J8.H g(Object, D0, Z0, K0)
  + J8.H h(Object, D0, Y0, K0)
  + J8.H i(E0) → List
  + J8.H l() → L0
  + J8.H n(Object, d, Y0, J0)
  + J8.H o(Object, r, Y0, I0)
  + J8.H p(Object, S0)
  + J8.I0 <init>(r)
  + J8.I0 equals(Object) → boolean
  + J8.I0 hashCode() → int
  + J8.I0 toString() → String
  + J8.J0 <init>(d)
  + J8.J b(Object, D0, Y0, K0, l)
  + J8.J c(E0) → boolean
  +
...✂

@amk-stripe amk-stripe marked this pull request as ready for review September 8, 2025 14:16
@amk-stripe amk-stripe requested review from a team as code owners September 8, 2025 14:16
@amk-stripe amk-stripe merged commit e83a49e into master Sep 8, 2025
16 checks passed
@amk-stripe amk-stripe deleted the ship-pay-now branch September 8, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toluo-stripe toluo-stripe toluo-stripe approved these changes

@tianzhao-stripe tianzhao-stripe Awaiting requested review from tianzhao-stripe tianzhao-stripe is a code owner automatically assigned from stripe/android-payments-reviewers

Assignees

No one assigned

Labels

PayNow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amk-stripe @toluo-stripe