KEMBAR78
Pass along `stripeAccountId` to `RetrieveStripeIntent` command by tillh-stripe · Pull Request #11568 · stripe/stripe-android · GitHub
Skip to content

Pass along stripeAccountId to RetrieveStripeIntent command #11568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2025
Merged

Pass along stripeAccountId to RetrieveStripeIntent command #11568

merged 3 commits into from
Sep 12, 2025

Conversation

@tillh-stripe
Copy link
Collaborator

@tillh-stripe tillh-stripe commented Sep 11, 2025 •
edited
Loading

Summary

This pull request fixes an issue where RetrieveStripeIntent doesn't use the connected account's ID when retrieving the intent.

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2025 •
edited
Loading

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │          compressed           │         uncompressed         
          ├───────────┬───────────┬───────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
      dex │   4.8 MiB │   4.8 MiB │ +34 B │  10.6 MiB │  10.6 MiB │ +4 B 
     arsc │   2.6 MiB │   2.6 MiB │   0 B │   2.6 MiB │   2.6 MiB │  0 B 
 manifest │   5.8 KiB │   5.8 KiB │   0 B │  30.4 KiB │  30.4 KiB │  0 B 
      res │ 927.6 KiB │ 927.6 KiB │   0 B │   1.5 MiB │   1.5 MiB │  0 B 
   native │   3.5 MiB │   3.5 MiB │   0 B │   8.5 MiB │   8.5 MiB │  0 B 
    asset │   1.6 MiB │   1.6 MiB │  -1 B │   1.6 MiB │   1.6 MiB │ -1 B 
    other │ 198.7 KiB │ 198.7 KiB │  +6 B │ 375.4 KiB │ 375.4 KiB │  0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
    total │  13.6 MiB │  13.6 MiB │ +39 B │  25.2 MiB │  25.2 MiB │ +3 B 

         │         raw          │          unique           
         ├───────┬───────┬──────┼───────┬───────┬───────────
 DEX     │ old   │ new   │ diff │ old   │ new   │ diff      
─────────┼───────┼───────┼──────┼───────┼───────┼───────────
   files │     2 │     2 │    0 │       │       │           
 strings │ 54220 │ 54220 │    0 │ 49959 │ 49959 │ 0 (+1 -1) 
   types │ 19520 │ 19520 │    0 │ 17418 │ 17418 │ 0 (+0 -0) 
 classes │ 14706 │ 14706 │    0 │ 14706 │ 14706 │ 0 (+0 -0) 
 methods │ 75237 │ 75237 │    0 │ 71922 │ 71922 │ 0 (+1 -1) 
  fields │ 49077 │ 49077 │    0 │ 47825 │ 47825 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6361 │ 6361 │  0
APK 
    compressed    │   uncompressed   │                               
──────────┬───────┼───────────┬──────┤                               
 size     │ diff  │ size      │ diff │ path                          
──────────┼───────┼───────────┼──────┼───────────────────────────────
  4.3 MiB │ +35 B │   9.4 MiB │ +4 B │ ∆ classes.dex                 
 55.2 KiB │  +5 B │ 122.4 KiB │  0 B │ ∆ META-INF/CERT.SF            
  9.4 KiB │  -1 B │   9.3 KiB │ -1 B │ ∆ assets/dexopt/baseline.prof 
  525 KiB │  -1 B │   1.2 MiB │  0 B │ ∆ classes2.dex                
 51.7 KiB │  +1 B │ 122.4 KiB │  0 B │ ∆ META-INF/MANIFEST.MF        
──────────┼───────┼───────────┼──────┼───────────────────────────────
  4.9 MiB │ +39 B │  10.9 MiB │ +3 B │ (total)
DEX 
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   49959 │ 49959 │ 0 (+1 -1) 
  
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"40bd4cf","r8-mode":"full","version":"8.8.34"}
  
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"2c13b30","r8-mode":"full","version":"8.8.34"}
  

METHODS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   71922 │ 71922 │ 0 (+1 -1) 
  
  + o8.h d(String, String, String, ContinuationImpl) → Object
  
  - o8.h d(String, String, ContinuationImpl) → Object

@tillh-stripe tillh-stripe force-pushed the tillh/retrieve-stripe-intent-connect branch from 9fcab18 to e3361fc Compare September 12, 2025 13:36
samer-stripe
samer-stripe previously approved these changes Sep 12, 2025
View reviewed changes
@tillh-stripe tillh-stripe marked this pull request as ready for review September 12, 2025 14:10
@tillh-stripe tillh-stripe requested review from a team as code owners September 12, 2025 14:10
@tillh-stripe tillh-stripe enabled auto-merge (squash) September 12, 2025 14:15
@tillh-stripe tillh-stripe merged commit 774aff2 into master Sep 12, 2025
16 checks passed
@tillh-stripe tillh-stripe deleted the tillh/retrieve-stripe-intent-connect branch September 12, 2025 14:29
cttsai-stripe pushed a commit that referenced this pull request Sep 15, 2025
@tillh-stripe @cttsai-stripe
Pass along stripeAccountId to RetrieveStripeIntent command (#11568)
86f8d30 
* Pass along `stripeAccountId` to `RetrieveStripeIntent` command

* Update tests

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samer-stripe samer-stripe samer-stripe approved these changes

@jaynewstrom-stripe jaynewstrom-stripe Awaiting requested review from jaynewstrom-stripe jaynewstrom-stripe is a code owner automatically assigned from stripe/android-payments-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tillh-stripe @samer-stripe