KEMBAR78
Add a memory viewer tool to TensorBoard profile plugin by qiuminxu · Pull Request #1223 · tensorflow/tensorboard · GitHub
Skip to content

Conversation

@qiuminxu
Copy link
Contributor

@qiuminxu qiuminxu commented Jun 4, 2018

The memory viewer tool visualizes the peak memory allocation and detailed breakdown of the logical buffers. This PR includes the main logics and there will be another including the line chart and a buffer detail card. The PR was migrated from internal JS implementation to TS.

screen shot 2018-06-04 at 8 15 26 am

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@qiuminxu qiuminxu force-pushed the master branch 4 times, most recently from a14aa92 to f56a1fa Compare June 4, 2018 18:36
@qiuminxu qiuminxu changed the base branch from master to 1.8 June 4, 2018 18:37
@qiuminxu qiuminxu changed the base branch from 1.8 to master June 4, 2018 18:37
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot
Copy link

CLAs look good, thanks!

@nfelt nfelt merged commit ee28b80 into tensorflow:master Jun 4, 2018
qiuminxu added a commit to qiuminxu/tensorboard that referenced this pull request Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants