KEMBAR78
Upgrade handlebars 4.7.3 -> 4.7.6 to avoid optimist dep by nfelt · Pull Request #3517 · tensorflow/tensorboard · GitHub
Skip to content

Upgrade handlebars 4.7.3 -> 4.7.6 to avoid optimist dep #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2020
Merged

Upgrade handlebars 4.7.3 -> 4.7.6 to avoid optimist dep #3517

merged 1 commit into from
Apr 14, 2020

Conversation

@nfelt
Copy link
Contributor

@nfelt nfelt commented Apr 14, 2020

This updates our yarn.lock file to bump our handlebars dep from 4.7.3 to 4.7.6 (the latest available release), which I did just by deleting the old entry and rerunning yarn install. This addresses the easy part of #3516 by picking up handlebars-lang/handlebars.js#1658 to prune a transitive dependency via optimist on an old version of minimist.

@nfelt nfelt requested a review from psybuzz April 14, 2020 05:26
stephanwlee
stephanwlee approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@stephanwlee stephanwlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will trust you that this won't create weird yarn.lock changes :)

psybuzz
psybuzz approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@psybuzz psybuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the minor version of Handlebars 4.6 and 4.7 doesn't have a matching minor equivalent internally. I'm not sure how strict we need to be with having the exact same version internally vs. external, but lgtm

@nfelt
Copy link
Contributor Author

nfelt commented Apr 14, 2020

Note that the minor version of Handlebars 4.6 and 4.7 doesn't have a matching minor equivalent internally. I'm not sure how strict we need to be with having the exact same version internally vs. external, but lgtm

Good point, but we're already pretty skewed (4.0.14 internally) so I figure a small amount more here is unlikely to cause issues.

@nfelt nfelt merged commit 76a7d69 into tensorflow:master Apr 14, 2020
@nfelt nfelt deleted the handlebars-update branch April 14, 2020 21:30
@nfelt nfelt mentioned this pull request Apr 15, 2020
Closed
caisq pushed a commit to caisq/tensorboard that referenced this pull request May 19, 2020
@nfelt @caisq
upgrade handlebars 4.7.3 -> 4.7.6 to avoid optimist dep (tensorflow#3517
de9f5e2 
)
caisq pushed a commit that referenced this pull request May 27, 2020
@nfelt @caisq
upgrade handlebars 4.7.3 -> 4.7.6 to avoid optimist dep (#3517)
45778f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psybuzz psybuzz psybuzz approved these changes

@stephanwlee stephanwlee stephanwlee approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nfelt @psybuzz @stephanwlee @googlebot