Bump Bazel minimum version to 2.1.0 to match CI #3535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanwlee
approved these changes
Apr 21, 2020
caisq
pushed a commit
to caisq/tensorboard
that referenced
this pull request
May 19, 2020
* Bump Bazel minimum version to 2.1.0 to match CI * Remove obsolete .bazelrc settings
caisq
pushed a commit
that referenced
this pull request
May 27, 2020
* Bump Bazel minimum version to 2.1.0 to match CI * Remove obsolete .bazelrc settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the minimum version of Bazel we require to build to 2.1.0 so it matches our CI. As the comment describes, these should stay in sync, since if we aren't actually building with the minimum version or running CI against it, it's easy for it to stop working without anyone noticing, at which point it can fail in a way that's harder to understand than the minimum version check.
If anyone really wants to try building with a lower Bazel version, they can always locally revert this change.
Also removes some .bazelrc options to not use Python toolchains; I'm not sure exactly at what point these become obsolete but they don't seem to have any impact on the build. Tested that building and running TensorBoard without these options still worked as expected.