Refactor logic common to send Tensors and Scalars #3537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identify tests in uploader_test.py that seem to specifically target logic in _ScalarBatchedRequestSender and rewrite them to only use _ScalarBatchedRequestSender and none of the layers above it. This is a useful exercise for the work on _TensorBatchedRequestSender so we can more easily identify which tests need to be written for it. We could also consider refactoring _ScalarBatchedRequestSender to its own file.
This refactors logic out of _ScalarBatchedRequestSender that will be reused in the future _TensorBatchRequestSender. Specifically we refactor logic for managing byte budget for requests and for pruning empty runs and tags. One test is refactored to use mocked _ByteBudgetManager.
bmd3k
commented
Apr 22, 2020
davidsoergel
approved these changes
Apr 23, 2020
caisq
pushed a commit
to caisq/tensorboard
that referenced
this pull request
May 19, 2020
The future _TensorBatchedRequestSender behaves similarly to the existing _ScalarBatchedRequestSender. This change refactors some of the less-trivial logic out from _ScalarBatchedRequestSender to be reused in _TensorBatchedRequestSender. Refactor logic for managing request byte budget into its own class and for pruning empty runs and tags into its own function. One test is improved to use mocked _ByteBudgetManager.
caisq
pushed a commit
that referenced
this pull request
May 27, 2020
The future _TensorBatchedRequestSender behaves similarly to the existing _ScalarBatchedRequestSender. This change refactors some of the less-trivial logic out from _ScalarBatchedRequestSender to be reused in _TensorBatchedRequestSender. Refactor logic for managing request byte budget into its own class and for pruning empty runs and tags into its own function. One test is improved to use mocked _ByteBudgetManager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The future _TensorBatchedRequestSender behaves similarly to the existing _ScalarBatchedRequestSender. This change refactors some of the less-trivial logic out from _ScalarBatchedRequestSender to be reused in _TensorBatchedRequestSender.
Refactor logic for managing request byte budget into its own class and for pruning empty runs and tags into its own function.
One test is improved to use mocked _ByteBudgetManager.