perf: apply layout/layer bound where possible #3642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a CSS/layout optimization for areas that renders a lot of DOM Nodes including the scrollable area. - will-change: transform <- hints browser to put the DOM in different GPu layer - contain <- hints browser that certain operations can be done by reasoning children only. For instance, when `size` is present, browser can calculate size/bounds by only reasoning with the child nodes.
nfelt
approved these changes
May 18, 2020
caisq
pushed a commit
to caisq/tensorboard
that referenced
this pull request
May 19, 2020
This is a CSS/layout optimization for areas that renders a lot of DOM Nodes including the scrollable area. - `will-change`: transform <- hints browser to put the DOM in different GPU layer - `contain` <- hints browser that certain operations can be done by reasoning children only. For instance, when `size` is present, browser can calculate size/bounds by only reasoning with the child nodes. For more information, refer to the [doc](https://developer.mozilla.org/en-US/docs/Web/CSS/contain).
caisq
pushed a commit
that referenced
this pull request
May 27, 2020
This is a CSS/layout optimization for areas that renders a lot of DOM Nodes including the scrollable area. - `will-change`: transform <- hints browser to put the DOM in different GPU layer - `contain` <- hints browser that certain operations can be done by reasoning children only. For instance, when `size` is present, browser can calculate size/bounds by only reasoning with the child nodes. For more information, refer to the [doc](https://developer.mozilla.org/en-US/docs/Web/CSS/contain).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a CSS/layout optimization for areas that renders a lot of DOM
Nodes including the scrollable area.
GPu layer
reasoning children only. For instance, when
sizeis present, browsercan calculate size/bounds by only reasoning with the child nodes.
For more information, refer to the doc.