line chart: zoom instruction show on top of other #5215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially with the customizable interactive view, the line chart interactive view is no longer on top of all the other DOM. This makes our zoom instruction which should appear above all is getting clipped or getting masked by other components. This change simply uses z-index: 1 (we do not use it elsewhere so 1 is sufficient; we rely on DOM ordering for the most part) to lift the DOM up.
bmd3k
approved these changes
Aug 10, 2021
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
Especially with the customizable interactive view, the line chart interactive view is no longer on top of all the other DOM. This makes our zoom instruction which should appear above all is getting clipped or getting masked by other components. This change simply uses z-index: 1 (we do not use it elsewhere so 1 is sufficient; we rely on DOM ordering for the most part) to lift the DOM up.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
Especially with the customizable interactive view, the line chart interactive view is no longer on top of all the other DOM. This makes our zoom instruction which should appear above all is getting clipped or getting masked by other components. This change simply uses z-index: 1 (we do not use it elsewhere so 1 is sufficient; we rely on DOM ordering for the most part) to lift the DOM up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially with the customizable interactive view, the line chart
interactive view is no longer on top of all the other DOM. This makes
our zoom instruction which should appear above all is getting clipped or
getting masked by other components. This change simply uses z-index: 1
(we do not use it elsewhere so 1 is sufficient; we rely on DOM ordering
for the most part) to lift the DOM up.