KEMBAR78
timeseries: debounce tag filter changes by stephanwlee · Pull Request #5265 · tensorflow/tensorboard · GitHub
Skip to content

Conversation

@stephanwlee
Copy link
Contributor

This puts debounce on the tag filter changes. Tag view does not have to
change on every keystroke so we put some debounce period so we can be
more performant by not updating too much.

This change also moves the plugin type filtering up since it does not change
too rapidly.

This puts debounce on the tag filter changes. Tag view does not have to
change on every keystroke so we put some debounce period so we can be
more performant by not updating too much.
@google-cla google-cla bot added the cla: yes label Aug 23, 2021
@stephanwlee stephanwlee requested a review from nfelt August 23, 2021 23:29
Copy link
Contributor

@nfelt nfelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, is the DeepReadonly actually needed for this change for some reason? Or is it just a drive-by cleanup? Or a separate perf improvement?

@stephanwlee
Copy link
Contributor Author

Just wondering, is the DeepReadonly actually needed for this change for some reason? Or is it just a drive-by cleanup? Or a separate perf improvement?

Because TypeScript compiler started to complain about the inferred type of the Observable, we had to strongly type it throughout and DeepReadonly is more correct type of the Observable as the Selector returns immutable version of the object. So, in short, yes, cleanup and was kind of warranted since we had to explicitly type the Observable throughout.

@stephanwlee stephanwlee merged commit b88b75d into tensorflow:master Aug 24, 2021
@stephanwlee stephanwlee deleted the improve4 branch August 24, 2021 00:39
yatbear pushed a commit to yatbear/tensorboard that referenced this pull request Mar 27, 2023
This puts debounce on the tag filter changes. Tag view does not have to
change on every keystroke so we put some debounce period so we can be
more performant by not updating too much.

This change also moves the plugin type filtering up since it does not change
too rapidly.
dna2github pushed a commit to dna2fork/tensorboard that referenced this pull request May 1, 2023
This puts debounce on the tag filter changes. Tag view does not have to
change on every keystroke so we put some debounce period so we can be
more performant by not updating too much.

This change also moves the plugin type filtering up since it does not change
too rapidly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants