timeseries: fix tags not fetching issue when loading #5300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were only waiting for navigation and plugin change events none of which is useful when freshly loading dashboard since `activePlugin` will be null until we can fetch the plugins listing at least once. This change, to fix the problem, also listens to plugins listing loaded event to assert and fetch the data.
stephanwlee
changed the title
bmd3k
approved these changes
Sep 9, 2021
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
Previously, we were only waiting for navigation and plugin change events none of which is useful when freshly loading dashboard since `activePlugin` will be null until we can fetch the plugins listing at least once. This change, to fix the problem, also listens to plugins listing loaded event to assert and fetch the data.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
Previously, we were only waiting for navigation and plugin change events none of which is useful when freshly loading dashboard since `activePlugin` will be null until we can fetch the plugins listing at least once. This change, to fix the problem, also listens to plugins listing loaded event to assert and fetch the data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were only waiting for navigation and plugin change events
none of which is useful when freshly loading dashboard since
activePluginwill be null until we can fetch the plugins listing atleast once. This change, to fix the problem, also listens to plugins
listing loaded event to assert and fetch the data.