layout: adjust contain style to show the expander #5503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmd3k
approved these changes
Jan 14, 2022
bmd3k
pushed a commit
to bmd3k/tensorboard
that referenced
this pull request
Jan 19, 2022
When the sidebar got resized and the width is small enough, we collapsed it. The bug is the expander used to reopen the sidebar disappears and the sidebar can never be expanded again. (What's worse is we remember this setting in local storage). This pr fixes the bug.
bmd3k
pushed a commit
that referenced
this pull request
Jan 20, 2022
When the sidebar got resized and the width is small enough, we collapsed it. The bug is the expander used to reopen the sidebar disappears and the sidebar can never be expanded again. (What's worse is we remember this setting in local storage). This pr fixes the bug.
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
When the sidebar got resized and the width is small enough, we collapsed it. The bug is the expander used to reopen the sidebar disappears and the sidebar can never be expanded again. (What's worse is we remember this setting in local storage). This pr fixes the bug.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
When the sidebar got resized and the width is small enough, we collapsed it. The bug is the expander used to reopen the sidebar disappears and the sidebar can never be expanded again. (What's worse is we remember this setting in local storage). This pr fixes the bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the sidebar got resized and the width is small enough, we collapsed it. The bug is the expander used to reopen the sidebar disappears and the sidebar can never be expanded again. (What's worse is we remember this setting in local storage)
before
after
The contain style is used to optimize the rendering, indicating the element might be independent of the rest of the dom tree. But for the expander, the width can't be sized without its descendants' sizes (the icon). Updates the contain to remove size from the consideration.
contain: content;is equivalent tocontain: layout paint