projector: fix controls help dialog button #6024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groszewn
approved these changes
Nov 4, 2022
qihach64
pushed a commit
to qihach64/tensorboard
that referenced
this pull request
Dec 19, 2022
## Motivation for features / changes On the embeddings projector, on the top left corner of the scatter plot there's an help icon (with a question mark) that when clicked should open a dialog showing an help for the controls in 3D and 2D mode. Currently the icon doesn't work and if clicked nothing happens. ## Technical description of changes Set a custom function on the `on-click` event of the `paper-icon-button`. ## Detailed steps to verify changes work correctly (as executed by you) - Open the embeddings projector - Click on the help icon (question mark, tooltip "Help with interaction control") - The help dialog should appear at the center of the page Co-authored-by: Marco Romanelli <mromanelli9@gmail.com>
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
## Motivation for features / changes On the embeddings projector, on the top left corner of the scatter plot there's an help icon (with a question mark) that when clicked should open a dialog showing an help for the controls in 3D and 2D mode. Currently the icon doesn't work and if clicked nothing happens. ## Technical description of changes Set a custom function on the `on-click` event of the `paper-icon-button`. ## Detailed steps to verify changes work correctly (as executed by you) - Open the embeddings projector - Click on the help icon (question mark, tooltip "Help with interaction control") - The help dialog should appear at the center of the page Co-authored-by: Marco Romanelli <mromanelli9@gmail.com>
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
## Motivation for features / changes On the embeddings projector, on the top left corner of the scatter plot there's an help icon (with a question mark) that when clicked should open a dialog showing an help for the controls in 3D and 2D mode. Currently the icon doesn't work and if clicked nothing happens. ## Technical description of changes Set a custom function on the `on-click` event of the `paper-icon-button`. ## Detailed steps to verify changes work correctly (as executed by you) - Open the embeddings projector - Click on the help icon (question mark, tooltip "Help with interaction control") - The help dialog should appear at the center of the page Co-authored-by: Marco Romanelli <mromanelli9@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
On the embeddings projector, on the top left corner of the scatter plot there's an help icon (with a question mark) that when clicked should open a dialog showing an help for the controls in 3D and 2D mode.
Currently the icon doesn't work and if clicked nothing happens.
Technical description of changes
Set a custom function on the
on-clickevent of thepaper-icon-button.Detailed steps to verify changes work correctly (as executed by you)