Embedding Projector: fix dark mode button contrast #6327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyajones
approved these changes
Apr 18, 2023
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
## Motivation for features / changes Help button cannot be seen in dark mode ## Technical description of changes force white background so the button is visible ## Screenshots of UI changes Before:  After: <img width="208" alt="Screenshot 2023-04-17 at 8 29 01 PM" src="https://user-images.githubusercontent.com/31378877/232663682-c67c5326-5713-4e6e-9ae5-3ac03dfc80b6.png"> ## Detailed steps to verify changes work correctly (as executed by you) turn on dark mode and verify the dialog button is visible ## Alternate designs / implementations considered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Help button cannot be seen in dark mode
Technical description of changes
force white background so the button is visible
Screenshots of UI changes
Before:
After:
Detailed steps to verify changes work correctly (as executed by you)
turn on dark mode and verify the dialog button is visible
Alternate designs / implementations considered