TF2 Upgrader: add support of ipynb files #25680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapted from original https://github.com/lc0/tf2-ipynb
|
I think once, #25653 is in, I can rebase this one |
martinwicke
requested changes
Feb 12, 2019
| parser = argparse.ArgumentParser( | ||
| formatter_class=argparse.RawDescriptionHelpFormatter, | ||
| description="""Convert a TensorFlow Python file to 2.0 | ||
| description="""Convert a TensorFlow Python file from 1.* to 2.0 |
There was a problem hiding this comment.
funny, since I started as 1.x, but in a header, it was already written as 1.*
| "--outfile=<output file> argument is required when converting a " | ||
| "single file.") | ||
| files_processed, report_text, errors = upgrade.process_file( | ||
| files_processed, report_text, errors = ipynb.process_file( |
There was a problem hiding this comment.
I'd prefer the filename selection logic to live here.
There was a problem hiding this comment.
Also, look at line 99, we should make sure that convert tree also understands ipynb files.
| files_processed, report_text, errors = \ | ||
| upgrader.process_file(in_filename, out_filename) | ||
|
|
||
| elif in_filename.endswith('.ipynb'): |
There was a problem hiding this comment.
Can you move the dispatch logic to the main function (and possibly maybe even process_tree)
pragyaak
added
size:M
|
@martinwicke Thanks for review, I've updated accordingly. |
tensorflowbutler
removed
the
stat:awaiting response
martinwicke
previously approved these changes
Feb 13, 2019
martinwicke
added
kokoro:force-run
pragyaak
added
ready to pull
lc0
force-pushed
the
tf2-ipynb-feature
branch
from
7a733d1 to
c9ee938
Compare
|
@martinwicke I fixed linter and other build issues. Please let me know if anything additional is missing. |
tensorflow-copybara
pushed a commit
that referenced
this pull request
Feb 25, 2019
PiperOrigin-RevId: 235546488
Merged
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 25, 2025
Imported from GitHub PR openxla/xla#25680 ROCm platform currently doesn't support **dot** --> **__triton_gemm** transformation for OCP FP8 data type. Copybara import of the project: -- 93b3c24e4727f3e80868a6c644d36ccc60fe0199 by scxfjiang <xuefei.jiang@amd.com>: disable triton fp8 gemm test in gpu compiler for ROCm -- 90960280448975109e560a5bbe885aff84e36b25 by scxfjiang <xuefei.jiang@amd.com>: remove unused variable Merging this change closes #25680 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#25680 from ROCm:ci_disable_triton_fp8_gemm_test_for_rocm 90960280448975109e560a5bbe885aff84e36b25 PiperOrigin-RevId: 751348460
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 25, 2025
Imported from GitHub PR openxla/xla#25680 ROCm platform currently doesn't support **dot** --> **__triton_gemm** transformation for OCP FP8 data type. Copybara import of the project: -- 93b3c24e4727f3e80868a6c644d36ccc60fe0199 by scxfjiang <xuefei.jiang@amd.com>: disable triton fp8 gemm test in gpu compiler for ROCm -- 90960280448975109e560a5bbe885aff84e36b25 by scxfjiang <xuefei.jiang@amd.com>: remove unused variable Merging this change closes #25680 PiperOrigin-RevId: 751368623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed @martinwicke, since locally it was tested in isolated environment, I would be more than happy to run the required tests
Potentially I'd follow with updating readme and other docs related things