KEMBAR78
fix: avoid side effects from `@typescript-eslint/typescript-estree` by SukkaW · Pull Request #146 · un-ts/eslint-plugin-import-x · GitHub
Skip to content

fix: avoid side effects from @typescript-eslint/typescript-estree #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 4, 2024
Merged

fix: avoid side effects from @typescript-eslint/typescript-estree #146

merged 3 commits into from
Sep 4, 2024

Conversation

@SukkaW
Copy link
Collaborator

@SukkaW SukkaW commented Sep 4, 2024

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: aefd0fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-import-x Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 4, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@antfu
Copy link
Contributor

antfu commented Sep 4, 2024

Thanks!

@Revadike
Copy link

Revadike commented Sep 4, 2024

Thank you, kind sir!

@SukkaW SukkaW merged commit e5e4580 into un-ts:master Sep 4, 2024
@github-actions github-actions bot mentioned this pull request Sep 4, 2024
Merged
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Sep 4, 2024
@renovate
fix(deps): update dependency eslint-plugin-import-x to v4.2.0
db3278d 
##### [v4.2.0](https://github.com/un-ts/eslint-plugin-import-x/blob/HEAD/CHANGELOG.md#420)

##### Minor Changes

-   [#142](un-ts/eslint-plugin-import-x#142) [`f12447e`](un-ts/eslint-plugin-import-x@f12447e) Thanks [@Zamiell](https://github.com/Zamiell)! - Add new option "whitelist" for rule "no-extraneous-dependencies"

##### Patch Changes

-   [#146](un-ts/eslint-plugin-import-x#146) [`e5e4580`](un-ts/eslint-plugin-import-x@e5e4580) Thanks [@SukkaW](https://github.com/SukkaW)! - Fix nuxt/eslint#494 by avoid importing from `@typescript-eslint/typescript-estree`.
@Revadike
Copy link

nuxt/eslint#494 (comment) 😞

@Revadike
Copy link

@SukkaW any idea why its happening again?

@SukkaW
Copy link
Collaborator Author

SukkaW commented Sep 16, 2024

@SukkaW any idea why its happening again?

Don;t know. Better run yarn dedupe or npx yarn-deduplicate yarn.lock first?

@Revadike
Copy link

Please check my reproduction https://github.com/Revadike/reproduction

@SukkaW any idea why its happening again?

Don;t know. Better run yarn dedupe or npx yarn-deduplicate yarn.lock first?

@SukkaW
Copy link
Collaborator Author

SukkaW commented Sep 16, 2024

https://github.com/Revadike/reproduction

image

I can't reproduce the issue using your repo. Locking my PR now.

@un-ts un-ts locked as resolved and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error: Cannot find module 'typescript'

3 participants

@SukkaW @antfu @Revadike