-
Notifications
You must be signed in to change notification settings - Fork 87
Closed
Labels
refactorInternal improvementInternal improvementrequires new majorThis would be a breaking changeThis would be a breaking changev25To be done in V25To be done in V25vaadin-login
Description
Motivation
Pre-requisite for #9699
Currently vaadin-login-form is using createRenderRoot() that returns this and then the actual wrapper with shadow DOM is vaadin-login-form-wrapper element. This is mainly due to historical reasons related to using Polymer template.
Also, in vaadin-login-overlay we have teleporting logic for footer and custom-form-area slots that moves slotted nodes to the form wrapper when the overlay opens. This is problematic, see vaadin/react-components#269.
Proposed solution
- Update
vaadin-login-formto have shadow DOM and placevaadin-login-form-wrapperthere - Make
<slot>elements invaadin-login-formthat would forward children to the form wrapper - Use slot controllers in
LoginFormMixinto create<form>, submit and forgot password buttons - Set
exportpartson thevaadin-login-form-wrapperto make::part()based styling work
Prototype: https://github.com/vaadin/web-components/compare/refactor/login-form-slotted
Additional context
This will enable us to add support for Flow counterpart APIs: vaadin/flow-components#5582
jouni
Metadata
Metadata
Assignees
Labels
refactorInternal improvementInternal improvementrequires new majorThis would be a breaking changeThis would be a breaking changev25To be done in V25To be done in V25vaadin-login