refactor!: update login-form to use shadow DOM and slotted form #9792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
commented
Jul 23, 2025
| return css` | ||
| :host { | ||
| display: block; | ||
| max-width: max-content; |
There was a problem hiding this comment.
Added this to make centering easier by setting margin: 0 auto on the form element.
This seems like a better option than using display: inline-block to me.
|
sissbruecker
approved these changes
Jul 24, 2025
|
This ticket/PR has been released with Vaadin 25.0.0-beta2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9694
Fixes #9793
vaadin-login-formto use shadow DOM and initialize slotted elements using controllers / Lit templateexportpartson the login-form-wrapper to make part elements stylable viavaadin-login-form::part()displaytoblockon the form wrapper as usinginline-blockcauses extra whitespace to be showninline-block<section part="form">and changedvaadin-login-form-wrapperto userole="region"part="form"will therefore be set on the login form wrapper itself now and still be available for stylingType of change
Note
Tested in screen readers and announcements look good, "Log In region" is announced:
VoiceOver
NVDA
JAWS