KEMBAR78
feat: add has-tooltip attribute to components supporting slotted tooltips by HerbertsVaadin · Pull Request #10028 · vaadin/web-components · GitHub
Skip to content

feat: add has-tooltip attribute to components supporting slotted tooltips #10028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 25, 2025
Merged

feat: add has-tooltip attribute to components supporting slotted tooltips #10028

merged 4 commits into from
Aug 25, 2025

Conversation

@HerbertsVaadin
Copy link
Collaborator

@HerbertsVaadin HerbertsVaadin commented Aug 19, 2025 •
edited by web-padawan
Loading

Description

Introducing has-tooltip attribute when a tooltip is used on component / element.
Also added has-tooltip attribute description to most components.

Related to #5094

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/pr
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.
  • I have not completed some of the steps above and my pull request can be closed immediately.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.
    (no Acceptance Criteria, but scope was defined)

Note

The following components have the has-tooltip attribute:

  • vaadin-accordion-panel
  • vaadin-avatar
  • vaadin-button
  • vaadin-checkbox
  • vaadin-checkbox-group
  • vaadin-combo-box
  • vaadin-custom-field
  • vaadin-date-picker
  • vaadin-date-time-picker
  • vaadin-email-field
  • vaadin-icon
  • vaadin-integer-field
  • vaadin-list-box
  • vaadin-message-input
  • vaadin-multi-select-combo-box
  • vaadin-number-field
  • vaadin-password-field
  • vaadin-select
  • vaadin-side-nav-item
  • vaadin-tab
  • vaadin-text-area
  • vaadin-text-field
  • vaadin-time-picker

@HerbertsVaadin HerbertsVaadin marked this pull request as ready for review August 19, 2025 10:51
@web-padawan web-padawan force-pushed the feat/sd-42-has-tooltip branch from 6b48919 to 227fa96 Compare August 25, 2025 08:18
@web-padawan web-padawan changed the title feat: Add has-tooltip attribute when tooltip used on component / element feat: add has-tooltip attribute to components using TooltipController Aug 25, 2025
web-padawan
web-padawan reviewed Aug 25, 2025
View reviewed changes
Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed my mind regarding setting has-tooltip on the target as it can end up with attribute being added to some unexpected elements. Updated to set has-tooltip only in components using TooltipController for now. Also reverted some JSDoc changes.

@web-padawan web-padawan force-pushed the feat/sd-42-has-tooltip branch from bddb9f1 to de1d5dc Compare August 25, 2025 09:44
@web-padawan web-padawan mentioned this pull request Aug 25, 2025
Merged
@web-padawan web-padawan force-pushed the feat/sd-42-has-tooltip branch 5 times, most recently from 2b4957a to 8cc084d Compare August 25, 2025 13:01
@web-padawan
Copy link
Member

Updated to not set has-tooltip for components using setManual(true) especially grid and menu-bar.
These will require adding separate logic to set has-tooltip on the menu-bar button, or part name on the cell.

IMO it can be addressed later in separate PRs, I'll merge this one as is and then look into menu-bar / grid.

@web-padawan web-padawan force-pushed the feat/sd-42-has-tooltip branch 5 times, most recently from e37c747 to 22b77bd Compare August 25, 2025 13:26
@web-padawan web-padawan force-pushed the feat/sd-42-has-tooltip branch from 22b77bd to eda4c81 Compare August 25, 2025 13:30
@web-padawan web-padawan changed the title feat: add has-tooltip attribute to components using TooltipController feat: add has-tooltip attribute to components supporting slotted tooltips Aug 25, 2025
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@web-padawan web-padawan merged commit 4110f05 into main Aug 25, 2025
9 checks passed
@web-padawan web-padawan deleted the feat/sd-42-has-tooltip branch August 25, 2025 13:51
web-padawan added a commit that referenced this pull request Aug 26, 2025
@HerbertsVaadin @web-padawan
feat: add has-tooltip attribute to components supporting slotted tool…
6fb6953 
…tip (#10028)

Co-authored-by: web-padawan <iamkulykov@gmail.com>
@web-padawan web-padawan mentioned this pull request Aug 26, 2025
Merged
web-padawan added a commit that referenced this pull request Aug 26, 2025
@web-padawan @HerbertsVaadin
feat: add has-tooltip attribute to components supporting slotted tool…
0ae6a43 
…tip (#10028) (#10076)

Co-authored-by: Herberts <80950643+HerbertsVaadin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@web-padawan web-padawan web-padawan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HerbertsVaadin @web-padawan