fix: use preventDefault for handling MDL escape press #10169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sissbruecker
approved these changes
Sep 16, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 16, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 16, 2025
web-padawan
added a commit
that referenced
this pull request
Sep 16, 2025
web-padawan
added a commit
that referenced
this pull request
Sep 16, 2025
|
This ticket/PR has been released with Vaadin 25.0.0-alpha12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using
stopPropagation()can be problematic in some cases. I noticed thatvaadin-selectinside of the MDL detail content doesn't close on Esc while reviewing #10157. Let's usepreventDefault()instead as we do elsewhere, example:web-components/packages/item/src/vaadin-item-mixin.js
Line 104 in db44120
Type of change