fix: update horizontal scroll position on data change #10192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Updating data can change the visibility of the scroll bar. Therefore, the scroll position | ||
| // has to be recalculated. | ||
| requestAnimationFrame(() => { | ||
| this.__updateHorizontalScrollPosition(); |
There was a problem hiding this comment.
We already have a resize observer on the table element:
web-components/packages/grid/src/vaadin-grid-mixin.js
Lines 266 to 271 in 587c730
Adding the scroll position update there also seems to work and might cover other scenarios as well?
There was a problem hiding this comment.
Thanks for the suggestion. I hadn't noticed the table resize observer. Updated the fix to call the update on table resize. Also updated the test and simplified it a little bit.
|
sissbruecker
approved these changes
Sep 23, 2025
ugur-vaadin
deleted the
fix-update-horizontal-scroll-position-on-data-change
branch
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 23, 2025
* fix: update horizontal scroll position on data change * refactor: update scroll position on table resize
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 23, 2025
* fix: update horizontal scroll position on data change * refactor: update scroll position on table resize
web-padawan
pushed a commit
that referenced
this pull request
Sep 23, 2025
web-padawan
pushed a commit
that referenced
this pull request
Sep 23, 2025
|
This ticket/PR has been released with Vaadin 25.0.0-alpha12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the data changes but there is no resize or scroll, the column widths are not recalculated with a new scroll position. On Windows, this leads to frozen-to-end columns not properly moved to the end, displaying data from other columns where the scroll bar was previously located.
This PR updates horizontal scroll position when the data changes. This makes sure that the frozen-to-end columns are always located at the end, even when there is no resize or scroll.
Fixes vaadin/flow-components#6666.
Type of change
Checklist