fix: ensure menu-bar is focusable after closing and moving focus #10273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
approved these changes
Oct 1, 2025
web-padawan
force-pushed
the
fix/menu-bar-focused-query-selector
branch
from
5591572 to
57a7652
Compare
|
vursen
approved these changes
Oct 1, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
web-padawan
added a commit
that referenced
this pull request
Oct 1, 2025
) (#10275) Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan
added a commit
that referenced
this pull request
Oct 1, 2025
) (#10276) Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
|
This ticket/PR has been released with Vaadin 25.0.0-alpha14. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10250
This fixes two problems in
vaadin-menu-bar, one of which is a V25 regression and the other one is not:querySelector('[tabindex="0]')can incorrectly return a sub-menu item from thesubmenuslottabNavigationI will create separate PRs to backport the corresponding
KeyboardDirectionMixinfix and tests to 24.9 and 24.8.Type of change