feat(FormLayout): add FormRow and br support to autoResponsive mode #8699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
changed the title
Base automatically changed from
feat/auto-responsive-form-layout-initial
to
feat/auto-responsive-form-layout
February 20, 2025 11:59
vursen
force-pushed
the
feat/auto-responsive-form-layout-line-breaks
branch
from
ba43675 to
a618c26
Compare
vursen
commented
Feb 20, 2025
There was a problem hiding this comment.
Currently, the component creates more columns than necessary. This is planned to be addressed within #8695.
vursen
commented
Feb 21, 2025
web-padawan
reviewed
Feb 24, 2025
web-padawan
reviewed
Feb 24, 2025
add entrypoints, screenshot tests minimize diff implement br support add snapshot tests update snapshot tests add more tests
Co-authored-by: Diego Cardoso <diego@vaadin.com>
vursen
force-pushed
the
feat/auto-responsive-form-layout-line-breaks
branch
from
ba305c9 to
a056bff
Compare
|
DiegoCardoso
approved these changes
Feb 24, 2025
web-padawan
approved these changes
Feb 24, 2025
vursen
added a commit
that referenced
this pull request
Feb 26, 2025
|
This ticket/PR has been released with Vaadin 24.8.0.rc2 and is also targeting the upcoming stable 24.8.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<vaadin-form-row>for arranging fields into rows<br>to provide the ability to force a new row when using autoRows.Fixes #8686
Type of change