refactor!: update login overlay to use native popover #9794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
refactor/native-popover-login
branch
5 times, most recently
from
30baab6 to
a320394
Compare
web-padawan
force-pushed
the
refactor/native-popover-login
branch
from
a320394 to
c1aaeb4
Compare
packages/login/src/styles/vaadin-login-overlay-wrapper-base-styles.js
Outdated
Show resolved
Hide resolved
|
sissbruecker
approved these changes
Jul 28, 2025
|
This ticket/PR has been released with Vaadin 25.0.0-beta2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9699
Depends on #9792
vaadin-login-overlayto use nativepopoverinstead of teleporting the content to the<body>title, and removedpart="title"from thevaadin-login-overlay-wrapperpart="form"in the overlay wrapper element toform-wrapper, usedformfor the actual formtheme="with-overlay"from the form wrapper as it's now directly slotted into the overlay wrapperNote, this change means that the component should be used outside any elements with shadow DOM in order for it to work with some password manager extensions. However, in general it should be ok as Flow component uses auto-add logic. The only problematic case is related to embedded web components, that needs further testing.
BTW, browser built-in password managers in Chrome (Brave) and Safari are not affected by shadow DOM and they work fine in current vaadin.com example which renders plain
vaadin-login-formin embedded component's shadow DOM.Type of change
Note
Flow components branch: https://github.com/vaadin/flow-components/compare/proto/login-overlay-popover