CNA: Add warning about permission #14889

matamatanot · 2020-07-06T14:26:41Z

I have some concerns.

import { isWriteable } from '../next/build/is-writeable' not from create-next-app package.
The warning sentence is from npm. Not for Next.js. I'm not a native English speaker. I'd like to know the natural expression for this.

ijjk · 2020-07-06T14:33:56Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
buildDuration	10.2s	10.5s	⚠️ +278ms
nodeModulesSize	66.1 MB	66.1 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.701	1.661	-0.04
/ avg req/sec	1469.8	1505.12	+35.32
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.027	0.978	-0.05
/error-in-render avg req/sec	2433.52	2557.34	+123.82

Client Bundles (main, webpack, commons)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..6834.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
main-HASH.module.js gzip	5.71 kB	5.71 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.09 kB	7.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
polyfills-HASH.js gzip	26.4 kB	26.4 kB	✓
Overall change	26.4 kB	26.4 kB	✓

Client Build Manifests

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Rendered Page Sizes

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
index.html gzip	953 B	953 B	✓
link.html gzip	959 B	959 B	✓
withRouter.html gzip	945 B	945 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
buildDuration	11.1s	11s	-103ms
nodeModulesSize	66.1 MB	66.1 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..6834.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
main-HASH.module.js gzip	5.71 kB	5.71 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.09 kB	7.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
polyfills-HASH.js gzip	26.4 kB	26.4 kB	✓
Overall change	26.4 kB	26.4 kB	✓

Client Build Manifests

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Serverless bundles

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_error.js	876 kB	876 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	876 kB	876 kB	✓
link.js	915 kB	915 kB	✓
routerDirect.js	908 kB	908 kB	✓
withRouter.js	908 kB	908 kB	✓
Overall change	4.49 MB	4.49 MB	✓

Commit: 449d2fd

ijjk · 2020-07-06T14:34:30Z

Failing test suites

Commit: 449d2fd

test/integration/create-next-app/index.test.js

create next app > empty directory
create next app > valid example
create next app > should allow example with GitHub URL
create next app > should allow example with GitHub URL and example-path
create next app > should use --example-path over the file path in the GitHub URL
create next app > should fall back to default template
create next app > should allow an example named default

Expand output

● create next app › empty directory

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js empty-directory

  58 |       await usingTempDir(async (cwd) => {
  59 |         const projectName = 'empty-directory'
> 60 |         const res = await runStarter(cwd, projectName)
     |                     ^
  61 | 
  62 |         expect(res.exitCode).toBe(0)
  63 |         expect(

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:60:21
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:58:7)

● create next app › valid example

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js valid-example --example basic-css

  90 |     await usingTempDir(async (cwd) => {
  91 |       const projectName = 'valid-example'
> 92 |       const res = await run(cwd, projectName, '--example', 'basic-css')
     |                   ^
  93 |       expect(res.exitCode).toBe(0)
  94 | 
  95 |       expect(

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:92:19
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:90:5)

● create next app › should allow example with GitHub URL

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-app --example https://github.com/zeit/next-learn-demo/tree/master/1-navigate-between-pages

  109 |     await usingTempDir(async (cwd) => {
  110 |       const projectName = 'github-app'
> 111 |       const res = await run(
      |                   ^
  112 |         cwd,
  113 |         projectName,
  114 |         '--example',

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:111:19
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:109:5)

● create next app › should allow example with GitHub URL and example-path

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-example-path --example https://github.com/zeit/next-learn-demo/tree/master --example-path 1-navigate-between-pages

  135 |     await usingTempDir(async (cwd) => {
  136 |       const projectName = 'github-example-path'
> 137 |       const res = await run(
      |                   ^
  138 |         cwd,
  139 |         projectName,
  140 |         '--example',

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:137:19
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:135:5)

● create next app › should use --example-path over the file path in the GitHub URL

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-example-path-2 --example https://github.com/zeit/next-learn-demo/tree/master/1-navigate-between-pages --example-path 1-navigate-between-pages

  163 |     await usingTempDir(async (cwd) => {
  164 |       const projectName = 'github-example-path-2'
> 165 |       const res = await run(
      |                   ^
  166 |         cwd,
  167 |         projectName,
  168 |         '--example',

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:165:19
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:163:5)

● create next app › should fall back to default template

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js fail-example --example __internal-testing-retry

  212 |         }
  213 | 
> 214 |         const res = await runExample(
      |                     ^
  215 |           'fail-example',
  216 |           '--example',
  217 |           '__internal-testing-retry'

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:214:21
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:194:7)

● create next app › should allow an example named default

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js default-example --example default

  225 |     await usingTempDir(async (cwd) => {
  226 |       const projectName = 'default-example'
> 227 |       const res = await run(cwd, projectName, '--example', 'default')
      |                   ^
  228 |       expect(res.exitCode).toBe(0)
  229 | 
  230 |       expect(

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:227:19
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:225:5)

ijjk · 2020-08-18T17:43:14Z

Failing test suites

Commit: 9cc2884

test/integration/create-next-app/index.test.js

create next app > empty directory
create next app > valid example
create next app > should allow example with GitHub URL
create next app > should allow example with GitHub URL and example-path
create next app > should use --example-path over the file path in the GitHub URL
create next app > should fall back to default template
create next app > should allow an example named default

Expand output

● create next app › empty directory

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js empty-directory

  58 |       await usingTempDir(async (cwd) => {
  59 |         const projectName = 'empty-directory'
> 60 |         const res = await runStarter(cwd, projectName)
     |                     ^
  61 | 
  62 |         expect(res.exitCode).toBe(0)
  63 |         expect(

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:60:21
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:58:7)

● create next app › valid example

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js valid-example --example basic-css

  90 |     await usingTempDir(async (cwd) => {
  91 |       const projectName = 'valid-example'
> 92 |       const res = await run(cwd, projectName, '--example', 'basic-css')
     |                   ^
  93 |       expect(res.exitCode).toBe(0)
  94 | 
  95 |       expect(

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:92:19
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:90:5)

● create next app › should allow example with GitHub URL

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-app --example https://github.com/zeit/next-learn-demo/tree/master/1-navigate-between-pages

  109 |     await usingTempDir(async (cwd) => {
  110 |       const projectName = 'github-app'
> 111 |       const res = await run(
      |                   ^
  112 |         cwd,
  113 |         projectName,
  114 |         '--example',

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:111:19
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:109:5)

● create next app › should allow example with GitHub URL and example-path

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-example-path --example https://github.com/zeit/next-learn-demo/tree/master --example-path 1-navigate-between-pages

  135 |     await usingTempDir(async (cwd) => {
  136 |       const projectName = 'github-example-path'
> 137 |       const res = await run(
      |                   ^
  138 |         cwd,
  139 |         projectName,
  140 |         '--example',

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:137:19
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:135:5)

● create next app › should use --example-path over the file path in the GitHub URL

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-example-path-2 --example https://github.com/zeit/next-learn-demo/tree/master/1-navigate-between-pages --example-path 1-navigate-between-pages

  163 |     await usingTempDir(async (cwd) => {
  164 |       const projectName = 'github-example-path-2'
> 165 |       const res = await run(
      |                   ^
  166 |         cwd,
  167 |         projectName,
  168 |         '--example',

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:165:19
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:163:5)

● create next app › should fall back to default template

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js fail-example --example __internal-testing-retry

  212 |         }
  213 | 
> 214 |         const res = await runExample(
      |                     ^
  215 |           'fail-example',
  216 |           '--example',
  217 |           '__internal-testing-retry'

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:214:21
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:194:7)

● create next app › should allow an example named default

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js default-example --example default

  225 |     await usingTempDir(async (cwd) => {
  226 |       const projectName = 'default-example'
> 227 |       const res = await run(cwd, projectName, '--example', 'default')
      |                   ^
  228 |       expect(res.exitCode).toBe(0)
  229 | 
  230 |       expect(

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:227:19
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:225:5)

ijjk · 2020-08-18T17:46:16Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
buildDuration	10.2s	10.3s	⚠️ +165ms
nodeModulesSize	57.6 MB	57.6 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.894	1.89	0
/ avg req/sec	1319.72	1323.04	+3.32
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.04	1.071	⚠️ +0.03
/error-in-render avg req/sec	2403.97	2334.52	⚠️ -69.45

Client Bundles (main, webpack, commons)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..4e55.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-1ea360d..8d32.js gzip	7.16 kB	7.16 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..dule.js gzip	6.11 kB	6.11 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-ece3b39..dule.js gzip	6.18 kB	6.18 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52 kB	52 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-1464c..a26f.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-000f151..65d4.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-e550f..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-4cfda7a..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
index.html gzip	947 B	947 B	✓
link.html gzip	952 B	952 B	✓
withRouter.html gzip	938 B	938 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
buildDuration	11.7s	11.6s	-101ms
nodeModulesSize	57.6 MB	57.6 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..4e55.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-1ea360d..8d32.js gzip	7.16 kB	7.16 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..dule.js gzip	6.11 kB	6.11 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-ece3b39..dule.js gzip	6.18 kB	6.18 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52 kB	52 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-1464c..a26f.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-000f151..65d4.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-e550f..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-4cfda7a..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.03 MB	1.03 MB	✓
link.js	1.07 MB	1.07 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.27 MB	5.27 MB	✓

Commit: 9cc2884

ijjk · 2020-08-18T17:50:57Z

Failing test suites

Commit: 530b91c

test/integration/create-next-app/index.test.js

create next app > empty directory
create next app > valid example
create next app > should allow example with GitHub URL
create next app > should allow example with GitHub URL and example-path
create next app > should use --example-path over the file path in the GitHub URL
create next app > should fall back to default template
create next app > should allow an example named default

Expand output

● create next app › empty directory

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js empty-directory

  58 |       await usingTempDir(async (cwd) => {
  59 |         const projectName = 'empty-directory'
> 60 |         const res = await runStarter(cwd, projectName)
     |                     ^
  61 | 
  62 |         expect(res.exitCode).toBe(0)
  63 |         expect(

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:60:21
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:58:7)

● create next app › valid example

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js valid-example --example basic-css

  90 |     await usingTempDir(async (cwd) => {
  91 |       const projectName = 'valid-example'
> 92 |       const res = await run(cwd, projectName, '--example', 'basic-css')
     |                   ^
  93 |       expect(res.exitCode).toBe(0)
  94 | 
  95 |       expect(

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:92:19
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:90:5)

● create next app › should allow example with GitHub URL

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-app --example https://github.com/zeit/next-learn-demo/tree/master/1-navigate-between-pages

  109 |     await usingTempDir(async (cwd) => {
  110 |       const projectName = 'github-app'
> 111 |       const res = await run(
      |                   ^
  112 |         cwd,
  113 |         projectName,
  114 |         '--example',

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:111:19
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:109:5)

● create next app › should allow example with GitHub URL and example-path

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-example-path --example https://github.com/zeit/next-learn-demo/tree/master --example-path 1-navigate-between-pages

  135 |     await usingTempDir(async (cwd) => {
  136 |       const projectName = 'github-example-path'
> 137 |       const res = await run(
      |                   ^
  138 |         cwd,
  139 |         projectName,
  140 |         '--example',

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:137:19
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:135:5)

● create next app › should use --example-path over the file path in the GitHub URL

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js github-example-path-2 --example https://github.com/zeit/next-learn-demo/tree/master/1-navigate-between-pages --example-path 1-navigate-between-pages

  163 |     await usingTempDir(async (cwd) => {
  164 |       const projectName = 'github-example-path-2'
> 165 |       const res = await run(
      |                   ^
  166 |         cwd,
  167 |         projectName,
  168 |         '--example',

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:165:19
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:163:5)

● create next app › should fall back to default template

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js fail-example --example __internal-testing-retry

  212 |         }
  213 | 
> 214 |         const res = await runExample(
      |                     ^
  215 |           'fail-example',
  216 |           '--example',
  217 |           '__internal-testing-retry'

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:214:21
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:194:7)

● create next app › should allow an example named default

Command failed with exit code 1 (EPERM): node /home/runner/work/next.js/next.js/packages/create-next-app/dist/index.js default-example --example default

  225 |     await usingTempDir(async (cwd) => {
  226 |       const projectName = 'default-example'
> 227 |       const res = await run(cwd, projectName, '--example', 'default')
      |                   ^
  228 |       expect(res.exitCode).toBe(0)
  229 | 
  230 |       expect(

  at makeError (../node_modules/execa/lib/error.js:58:11)
  at handlePromise (../node_modules/execa/index.js:112:26)
  at integration/create-next-app/index.test.js:227:19
  at usingTempDir (integration/create-next-app/index.test.js:30:12)
  at Object.<anonymous> (integration/create-next-app/index.test.js:225:5)

ijjk · 2020-08-18T17:54:14Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
buildDuration	10.2s	10.1s	-105ms
nodeModulesSize	57.6 MB	57.6 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.82	1.853	⚠️ +0.03
/ avg req/sec	1373.87	1348.94	⚠️ -24.93
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.018	1.022	0
/error-in-render avg req/sec	2455.07	2445.54	⚠️ -9.53

Client Bundles (main, webpack, commons)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..4e55.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-1ea360d..8d32.js gzip	7.16 kB	7.16 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..dule.js gzip	6.11 kB	6.11 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-ece3b39..dule.js gzip	6.18 kB	6.18 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52 kB	52 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-1464c..a26f.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-000f151..65d4.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-e550f..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-4cfda7a..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
index.html gzip	947 B	947 B	✓
link.html gzip	952 B	952 B	✓
withRouter.html gzip	938 B	938 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
buildDuration	11.5s	11.5s	⚠️ +66ms
nodeModulesSize	57.6 MB	57.6 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..4e55.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-1ea360d..8d32.js gzip	7.16 kB	7.16 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..dule.js gzip	6.11 kB	6.11 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-ece3b39..dule.js gzip	6.18 kB	6.18 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52 kB	52 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-1464c..a26f.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-000f151..65d4.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-e550f..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-4cfda7a..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.03 MB	1.03 MB	✓
link.js	1.07 MB	1.07 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.27 MB	5.27 MB	✓

Commit: 530b91c

ijjk · 2020-08-19T00:52:52Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
buildDuration	9.8s	9.9s	⚠️ +154ms
nodeModulesSize	57.7 MB	57.7 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.808	1.863	⚠️ +0.05
/ avg req/sec	1382.95	1342.26	⚠️ -40.69
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.019	1.072	⚠️ +0.05
/error-in-render avg req/sec	2454.45	2331.91	⚠️ -122.54

Client Bundles (main, webpack, commons)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..4e55.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-8da9cf5..55dc.js gzip	7.18 kB	7.18 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..dule.js gzip	6.11 kB	6.11 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-e458620..dule.js gzip	6.2 kB	6.2 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52 kB	52 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-1464c..a26f.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-000f151..65d4.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-e550f..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-4cfda7a..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
index.html gzip	947 B	947 B	✓
link.html gzip	953 B	953 B	✓
withRouter.html gzip	938 B	938 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
buildDuration	11.1s	11.6s	⚠️ +500ms
nodeModulesSize	57.7 MB	57.7 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..4e55.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-8da9cf5..55dc.js gzip	7.18 kB	7.18 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..dule.js gzip	6.11 kB	6.11 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-e458620..dule.js gzip	6.2 kB	6.2 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52 kB	52 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-1464c..a26f.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-000f151..65d4.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-e550f..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-4cfda7a..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.03 MB	1.03 MB	✓
link.js	1.07 MB	1.07 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.27 MB	5.27 MB	✓

Commit: 2d5e18e

ijjk · 2020-08-19T01:34:53Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
buildDuration	12.8s	12.8s	-23ms
nodeModulesSize	57.7 MB	57.7 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.413	2.445	⚠️ +0.03
/ avg req/sec	1035.92	1022.48	⚠️ -13.44
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.451	1.486	⚠️ +0.03
/error-in-render avg req/sec	1722.84	1682.68	⚠️ -40.16

Client Bundles (main, webpack, commons)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..4e55.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-8da9cf5..55dc.js gzip	7.18 kB	7.18 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..dule.js gzip	6.11 kB	6.11 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-e458620..dule.js gzip	6.2 kB	6.2 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52 kB	52 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-1464c..a26f.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-000f151..65d4.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-e550f..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-4cfda7a..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
index.html gzip	947 B	947 B	✓
link.html gzip	953 B	953 B	✓
withRouter.html gzip	938 B	938 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
buildDuration	14.6s	14.3s	-335ms
nodeModulesSize	57.7 MB	57.7 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..4e55.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-8da9cf5..55dc.js gzip	7.18 kB	7.18 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..dule.js gzip	6.11 kB	6.11 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-e458620..dule.js gzip	6.2 kB	6.2 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52 kB	52 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-1464c..a26f.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-000f151..65d4.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-e550f..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-4cfda7a..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.03 MB	1.03 MB	✓
link.js	1.07 MB	1.07 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.27 MB	5.27 MB	✓

Commit: 5f46a01

lfades

Hi @matamatanot Thank you for the PR and sorry for the late review, it was missing some changes and tests

@ijjk @Timer Could one of you do a review of the PR 🙏 . I updated it and I shouldn't review my own changes.

packages/create-next-app/create-app.ts

ijjk · 2020-08-19T16:54:22Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
buildDuration	12.5s	12.4s	-136ms
nodeModulesSize	57.7 MB	57.7 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.242	2.252	⚠️ +0.01
/ avg req/sec	1115.08	1110.07	⚠️ -5.01
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.316	1.247	-0.07
/error-in-render avg req/sec	1900.17	2004.61	+104.44

Client Bundles (main, webpack, commons)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..4e55.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-512d5b9..081a.js gzip	7.2 kB	7.2 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..dule.js gzip	6.11 kB	6.11 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-1203ff1..dule.js gzip	6.21 kB	6.21 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52 kB	52 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-1464c..a26f.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-000f151..65d4.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-e550f..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-4cfda7a..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
index.html gzip	949 B	949 B	✓
link.html gzip	955 B	955 B	✓
withRouter.html gzip	940 B	940 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
buildDuration	14.3s	13.7s	-590ms
nodeModulesSize	57.7 MB	57.7 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..4e55.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-512d5b9..081a.js gzip	7.2 kB	7.2 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..dule.js gzip	6.11 kB	6.11 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-1203ff1..dule.js gzip	6.21 kB	6.21 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52 kB	52 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-1464c..a26f.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-000f151..65d4.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-e550f..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-4cfda7a..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.03 MB	1.03 MB	✓
link.js	1.07 MB	1.07 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.27 MB	5.27 MB	✓

Commit: e5479a7

ijjk · 2020-08-19T16:58:25Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
buildDuration	12.2s	12.5s	⚠️ +267ms
nodeModulesSize	57.7 MB	57.7 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.24	2.241	0
/ avg req/sec	1116.22	1115.78	⚠️ -0.44
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.231	1.207	-0.02
/error-in-render avg req/sec	2030.5	2071.2	+40.7

Client Bundles (main, webpack, commons)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..4e55.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-512d5b9..081a.js gzip	7.2 kB	7.2 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..dule.js gzip	6.11 kB	6.11 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-1203ff1..dule.js gzip	6.21 kB	6.21 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52 kB	52 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-1464c..a26f.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-000f151..65d4.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-e550f..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-4cfda7a..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
index.html gzip	949 B	949 B	✓
link.html gzip	955 B	955 B	✓
withRouter.html gzip	940 B	940 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
buildDuration	13.9s	14s	⚠️ +118ms
nodeModulesSize	57.7 MB	57.7 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..4e55.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-512d5b9..081a.js gzip	7.2 kB	7.2 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
677f882d2ed8..dule.js gzip	6.11 kB	6.11 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-1203ff1..dule.js gzip	6.21 kB	6.21 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52 kB	52 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-1464c..a26f.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-000f151..65d4.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-e550f..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-4cfda7a..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	matamatanot/next.js cna-warning-permission	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.03 MB	1.03 MB	✓
link.js	1.07 MB	1.07 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.27 MB	5.27 MB	✓

Commit: 896f7b1

close vercel#14744 <img width="851" alt="screen_shot" src="https://user-images.githubusercontent.com/39780486/86603491-06bec800-bfdf-11ea-9928-ee85cbad86a7.png"> I have some concerns. - `import { isWriteable } from '../next/build/is-writeable'` **not** from `create-next-app ` package. - The warning sentence is from npm. Not for Next.js. I'm not a native English speaker. I'd like to know the natural expression for this.

add warning about permission

449d2fd

matamatanot requested review from Timer, ijjk, lfades and timneutkens as code owners July 6, 2020 14:26

ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Jul 6, 2020

matamatanot changed the title ~~CNA: Add warning about permission.~~ CNA: Add warning about permission Jul 7, 2020

Merge branch 'canary' into cna-warning-permission

9cc2884

Move util to the package

530b91c

lfades added 2 commits August 18, 2020 19:43

Add broken test

7ce1839

Fixed check

2d5e18e

Updated test to support Windows

5f46a01

lfades reviewed Aug 19, 2020

View reviewed changes

ijjk reviewed Aug 19, 2020

View reviewed changes

packages/create-next-app/create-app.ts Outdated Show resolved Hide resolved

ijjk reviewed Aug 19, 2020

View reviewed changes

packages/create-next-app/create-app.ts Outdated Show resolved Hide resolved

ijjk requested a review from lfades August 19, 2020 15:09

Added JJ suggestion

e5479a7

lfades requested a review from ijjk August 19, 2020 16:46

ijjk approved these changes Aug 19, 2020

View reviewed changes

Merge branch 'canary' into cna-warning-permission

896f7b1

kodiakhq bot merged commit 0226e78 into vercel:canary Aug 19, 2020

matamatanot deleted the cna-warning-permission branch August 19, 2020 19:08

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

CNA: Add warning about permission #14889

CNA: Add warning about permission #14889

Uh oh!

Conversation

matamatanot commented Jul 6, 2020

Uh oh!

ijjk commented Jul 6, 2020

Stats from current PR

Uh oh!

ijjk commented Jul 6, 2020

Failing test suites

Uh oh!

ijjk commented Aug 18, 2020

Failing test suites

Uh oh!

ijjk commented Aug 18, 2020

Stats from current PR

Uh oh!

ijjk commented Aug 18, 2020

Failing test suites

Uh oh!

ijjk commented Aug 18, 2020

Stats from current PR

Uh oh!

ijjk commented Aug 19, 2020

Stats from current PR

Uh oh!

ijjk commented Aug 19, 2020

Stats from current PR

Uh oh!

lfades left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ijjk commented Aug 19, 2020

Stats from current PR

Uh oh!

ijjk commented Aug 19, 2020

Stats from current PR

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants